From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IllgB-0007CT-Nx for qemu-devel@nongnu.org; Sat, 27 Oct 2007 09:26:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IllgA-0007CH-AV for qemu-devel@nongnu.org; Sat, 27 Oct 2007 09:26:18 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IllgA-0007CE-3c for qemu-devel@nongnu.org; Sat, 27 Oct 2007 09:26:18 -0400 Received: from relay01.mx.bawue.net ([193.7.176.67]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Illg9-0002fu-JO for qemu-devel@nongnu.org; Sat, 27 Oct 2007 09:26:18 -0400 Date: Sat, 27 Oct 2007 14:26:13 +0100 From: Thiemo Seufer Subject: Re: [Qemu-devel] [PATCH] strace rework Message-ID: <20071027132612.GK29176@networkno.de> References: <1193063060.5068.45.camel@phantasm.home.enterpriseandprosperity.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <1193063060.5068.45.camel@phantasm.home.enterpriseandprosperity.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thayne Harbaugh Cc: qemu-devel Thayne Harbaugh wrote: > This is a rework of Stuart Anderson's strace patch. I've fixed > target-to-host and host-to-target syscall lookups so that the proper > host or target errno is returned. It didn't build for me due to the a missing target_to_host_errno function. Could you also have a look at the compiler warnings =66rom strace.c? I see e.g.: gcc-3.4 -Wall -O2 -g -fno-strict-aliasing -I. -I.. -I/home/ths/qemu/qemu-wo= rk/target-ppc -I/home/ths/qemu/qemu-work -I/home/ths/qemu/qemu-work/linux-u= ser -I/home/ths/qemu/qemu-work/linux-user/ppc -D__powerpc__ -D_GNU_SOURCE -= D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE -I/home/ths/qemu/qemu-work/fpu = -DHAS_AUDIO -DHAS_AUDIO_CHOICE -I/home/ths/qemu/qemu-work/slirp -c -o st= race.o /home/ths/qemu/qemu-work/linux-user/strace.c /home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_newselect': /home/ths/qemu/qemu-work/linux-user/strace.c:111: warning: int format, long= int arg (arg 3) /home/ths/qemu/qemu-work/linux-user/strace.c:112: warning: passing arg 2 of= `print_fdset' makes pointer from integer without a cast /home/ths/qemu/qemu-work/linux-user/strace.c:114: warning: passing arg 2 of= `print_fdset' makes pointer from integer without a cast /home/ths/qemu/qemu-work/linux-user/strace.c:116: warning: passing arg 2 of= `print_fdset' makes pointer from integer without a cast /home/ths/qemu/qemu-work/linux-user/strace.c:118: warning: passing arg 1 of= `print_timeval' makes pointer from integer without a cast /home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_semctl': /home/ths/qemu/qemu-work/linux-user/strace.c:133: warning: int format, long= int arg (arg 3) /home/ths/qemu/qemu-work/linux-user/strace.c:133: warning: int format, long= int arg (arg 4) /home/ths/qemu/qemu-work/linux-user/strace.c:135: warning: format argument = is not a pointer (arg 2) /home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_execve': /home/ths/qemu/qemu-work/linux-user/strace.c:142: warning: initialization m= akes pointer from integer without a cast /home/ths/qemu/qemu-work/linux-user/strace.c:145: warning: format argument = is not a pointer (arg 3) /home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_ipc': /home/ths/qemu/qemu-work/linux-user/strace.c:164: warning: int format, long= int arg (arg 3) /home/ths/qemu/qemu-work/linux-user/strace.c:164: warning: int format, long= int arg (arg 4) /home/ths/qemu/qemu-work/linux-user/strace.c:164: warning: int format, long= int arg (arg 5) /home/ths/qemu/qemu-work/linux-user/strace.c:164: warning: int format, long= int arg (arg 6) /home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_syscall_re= t_addr': /home/ths/qemu/qemu-work/linux-user/strace.c:178: warning: unsigned int for= mat, long int arg (arg 2) /home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_syscall_re= t_raw': /home/ths/qemu/qemu-work/linux-user/strace.c:185: warning: unsigned int for= mat, long int arg (arg 2) /home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_syscall_re= t_newselect': /home/ths/qemu/qemu-work/linux-user/strace.c:191: warning: unsigned int for= mat, long int arg (arg 2) /home/ths/qemu/qemu-work/linux-user/strace.c:192: warning: passing arg 2 of= `print_fdset' makes pointer from integer without a cast /home/ths/qemu/qemu-work/linux-user/strace.c:194: warning: passing arg 2 of= `print_fdset' makes pointer from integer without a cast /home/ths/qemu/qemu-work/linux-user/strace.c:196: warning: passing arg 2 of= `print_fdset' makes pointer from integer without a cast /home/ths/qemu/qemu-work/linux-user/strace.c:198: warning: passing arg 1 of= `print_timeval' makes pointer from integer without a cast /home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_syscall': /home/ths/qemu/qemu-work/linux-user/strace.c:222: warning: implicit declara= tion of function `getpid' /home/ths/qemu/qemu-work/linux-user/strace.c: In function `print_syscall_re= t': /home/ths/qemu/qemu-work/linux-user/strace.c:249: warning: int format, long= int arg (arg 2) /home/ths/qemu/qemu-work/linux-user/strace.c:251: warning: int format, long= int arg (arg 2) /home/ths/qemu/qemu-work/linux-user/strace.c: At top level: /home/ths/qemu/qemu-work/linux-user/strace.c:184: warning: 'print_syscall_r= et_raw' defined but not used Thiemo