From: Sam Ravnborg <sam@ravnborg.org>
To: Joe Perches <joe@perches.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
akpm@osdl.org, torvalds@osdl.org, viro@zeniv.linux.org.uk,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH] proc_fs.h redux
Date: Sun, 28 Oct 2007 09:44:41 +0100 [thread overview]
Message-ID: <20071028084441.GA24221@uranus.ravnborg.org> (raw)
In-Reply-To: <1193524804.26695.103.camel@localhost>
>
> As a general rule, I think it better to use includes
> than use naked forward declarations.
Quite the opposite - at least in the kernel source.
The general rule is that a .h file shall include the
.h files which contain declarations used by said .h files.
But naked declarations as above is preferred over including
a full header file.
We see the full header dependency thing to blow off when
inline function are used - which is more and more the case.
In several cases we have converted inline functions to macros
just to simplify the nightmare of header dependencies we have.
Arnaldo have a nice script that generate a .ps file
showing all the dependencies.
He lately posted this URL: http://oops.ghostprotocols.net:81/acme/tcp.h.ps
Sam
next prev parent reply other threads:[~2007-10-28 8:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-27 19:47 [PATCH] proc_fs.h redux Alexey Dobriyan
2007-10-27 22:40 ` Joe Perches
2007-10-28 7:02 ` Alexey Dobriyan
2007-10-28 8:44 ` Sam Ravnborg [this message]
2007-10-29 13:03 ` Arnaldo Carvalho de Melo
2007-10-28 10:34 ` Russell King
2007-10-28 10:43 ` Jan Engelhardt
2007-10-28 11:59 ` Bernhard Walle
2007-10-28 13:04 ` Russell King
2007-10-28 13:04 ` Russell King
2007-10-28 13:25 ` Bernhard Walle
2007-10-28 17:58 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071028084441.GA24221@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=joe@perches.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.