From: Ralf Baechle <ralf@linux-mips.org>
To: Thiemo Seufer <ths@networkno.de>
Cc: linux-mips@linux-mips.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Fix/Rewrite of the mipsnet driver
Date: Mon, 29 Oct 2007 00:25:17 +0000 [thread overview]
Message-ID: <20071029002517.GB16913@linux-mips.org> (raw)
In-Reply-To: <20071028043846.GM29176@networkno.de>
On Sun, Oct 28, 2007 at 04:38:46AM +0000, Thiemo Seufer wrote:
> Hello All,
>
> currently the mipsnet driver fails after transmitting a number of
> packages because SKBs are allocated but never freed. I fixed that
> and coudn't refrain from removing the most egregious warts.
>
> - mipsnet.h folded into mipsnet.c, as it doesn't provide any
> useful external interface.
> - Free SKB after transmission.
> - Call free_irq in mipsnet_close, to balance the request_irq in
> mipsnet_open.
> - Removed duplicate read of rxDataCount.
> - Some identifiers are now less verbose.
> - Removed dead and/or unnecessarily complex code.
> - Code formatting fixes.
>
> Tested on Qemu's mipssim emulation, with this patch it can boot a
> Debian NFSroot.
The patch does no longer apply to a recent tree, can you respin it?
Ralf
next prev parent reply other threads:[~2007-10-28 17:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-28 4:38 [PATCH] Fix/Rewrite of the mipsnet driver Thiemo Seufer
2007-10-29 0:25 ` Ralf Baechle [this message]
2007-10-28 20:03 ` Thiemo Seufer
2007-10-28 20:22 ` Stephen Hemminger
2007-10-28 20:38 ` Thiemo Seufer
2007-10-28 20:40 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071029002517.GB16913@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ths@networkno.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.