From: Olof Johansson <olof@lixom.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc: Fix demotion of segments to 4K pages
Date: Sun, 28 Oct 2007 20:50:14 -0500 [thread overview]
Message-ID: <20071029015014.GA13687@lixom.net> (raw)
In-Reply-To: <1193619918.9928.0.camel@pasglop>
Hi Ben,
On Mon, Oct 29, 2007 at 12:05:18PM +1100, Benjamin Herrenschmidt wrote:
> @@ -887,6 +886,9 @@ void hash_preload(struct mm_struct *mm,
> local_irq_restore(flags);
> }
>
> +/* WARNING: This is called from hash_low_64.S, if you change this prototype,
> + * do not forget to update the assembly call site !
> + */
Since we're already policing whitespace on this list today: We're normally
not using spaces before exclamation marks.
-Olof
next prev parent reply other threads:[~2007-10-29 1:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 1:05 [PATCH] powerpc: Fix demotion of segments to 4K pages Benjamin Herrenschmidt
2007-10-29 1:50 ` Olof Johansson [this message]
2007-10-29 2:00 ` Benjamin Herrenschmidt
2007-10-29 3:06 ` Olof Johansson
2007-10-29 3:24 ` Benjamin Herrenschmidt
2007-10-29 8:32 ` Geert Uytterhoeven
2007-10-29 2:18 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071029015014.GA13687@lixom.net \
--to=olof@lixom.net \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.