From: Dirk Hohndel <hohndel@linux.intel.com>
To: Jiri Kosina <jikos@jikos.cz>
Cc: linux-input@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device
Date: Sun, 28 Oct 2007 23:51:53 -0700 [thread overview]
Message-ID: <20071029065153.GA9490@bigserver.hohndel.org> (raw)
[INPUT] hidinput_connect incorrectly ignored return value from input_register_device
Signed-off-by: Dirk Hohndel <hohndel@linux.intel.com>
---
drivers/hid/hid-input.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index dd332f2..c8640e7 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -1186,13 +1186,19 @@ int hidinput_connect(struct hid_device *hid)
* UGCI) cram a lot of unrelated inputs into the
* same interface. */
hidinput->report = report;
- input_register_device(hidinput->input);
+ if (input_register_device(hidinput->input)) {
+ input_free_device(hidinput->input);
+ return -1;
+ }
hidinput = NULL;
}
}
if (hidinput)
- input_register_device(hidinput->input);
+ if (input_register_device(hidinput->input)) {
+ input_free_device(hidinput->input);
+ return -1;
+ }
return 0;
}
--
gitgui.0.8.4.g8d863
next reply other threads:[~2007-10-29 6:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 6:51 Dirk Hohndel [this message]
2007-10-29 7:53 ` [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device Jeff Garzik
2007-10-29 8:49 ` Dirk Hohndel
2007-10-29 9:35 ` Jeff Garzik
2007-10-29 10:14 ` Jiri Kosina
2007-10-29 12:54 ` Dmitry Torokhov
2007-10-29 12:57 ` Jiri Kosina
2007-10-29 14:49 ` Jeff Garzik
2007-10-29 15:20 ` Dirk Hohndel
2007-10-29 15:33 ` Dmitry Torokhov
2007-10-29 15:38 ` Hohndel, Dirk
2007-10-29 17:11 ` Dmitry Torokhov
2007-10-29 17:28 ` Jiri Kosina
2007-10-29 22:50 ` Dirk Hohndel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071029065153.GA9490@bigserver.hohndel.org \
--to=hohndel@linux.intel.com \
--cc=jikos@jikos.cz \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.