From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ImVcE-00072b-Vd
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:29:18 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ImVcE-00070o-8d
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:29:18 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ImVcE-00070Z-1B
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:29:18 -0400
Received: from volumehost.com ([69.150.104.236])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <risc@volumehost.com>) id 1ImVcC-00033o-Ss
	for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:29:17 -0400
Date: Mon, 29 Oct 2007 08:07:29 -0600
From: risc@volumehost.com
Subject: Re: [Qemu-devel] [PATCH 1/3] Add args to -cdrom to define where is
	connected the cdrom
Message-ID: <20071029140729.GK12592@volumehost.com>
References: <11936114152690-git-send-email-Laurent.Vivier@bull.net>
	<11936114153499-git-send-email-Laurent.Vivier@bull.net>
	<20071029132525.GA7128@redhat.com> <4725E7ED.6050305@bull.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <4725E7ED.6050305@bull.net>
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Mon, Oct 29, 2007 at 03:02:21PM +0100, Laurent Vivier wrote:
> Daniel P. Berrange a =E9crit :
> >On Sun, Oct 28, 2007 at 11:43:33PM +0100, Laurent.Vivier@bull.net wrot=
e:
> >>From: Laurent Vivier <vivierl@frecb07144.(none)>
> >>
> >>This patch allows to define where is connected the CDROM device (bus,
> >>unit).
> >>It extends the "-cdrom" syntax to add these paramaters:
> >>
> >>     -cdrom file[,if=3Dtype][,bus=3Dn][,unit=3Dm]
> >>
> >> where "type" defines the interface (by default, "ide")
> >>       "n" defines the bus number (by default 1)
> >>       "m" defines the unit number (by default 0)
> >
> >
> >Having a separately named arg just for CDROMs was always rather=20
> >odd/unhelpful.
> >I'd suggest that we leave all the -hda,hdb,hdc,-cdrom,-fda,-fdb etc=20
> >unchanged
> >and use the -disk for setting up all types of disks, floppys, cdroms, =
etc.=20
> >It
> >would just require one extra field for the -disk arg:
> >
> >      -disk file[,if=3Dtype][,bus=3Dn][,unit=3Dm][,mode=3Dmode]
> >=20
> >  where "type" defines the interface. [ide,scsi,fd] (by default, "ide"=
)
> >        "n" defines the bus number (by default 1)
> >        "m" defines the unit number (by default 0)
> >        "mode" defines one of [disk,floppy,cdrom]
> >
> >If we ever up able to emulate other types of SCSI / IDE devices (tape=20
> >drives,
> >cdr, dvd perhaps) then the 'mode' can easily be extended to cover them.
>=20
> I agree with that. And if everyone agrees I can modify patches to do th=
at...
>=20
> Laurent
> --=20
> ---------------- Laurent.Vivier@bull.net  -----------------
> "Given enough eyeballs, all bugs are shallow" E. S. Raymond
>=20
>=20
>=20
not to be rude, but "my" version of the scsi patch supports three control=
lers,
for a total of 21 disks. might i reccomend you impliment -disk with a con=
troller,
bus, target syntax, ALA sun?

Julia Longtin <risc@volumehost.com>