Re: [Qemu-devel] [PATCH 1/3] Add args to -cdrom to define where is connected the cdrom

[Thiemo Seufer <ths@networkno.de>]

andrzej zaborowski wrote:
> On 29/10/2007, Daniel P. Berrange <berrange@redhat.com> wrote:
> > On Sun, Oct 28, 2007 at 11:43:33PM +0100, Laurent.Vivier@bull.net wrote:
> > > From: Laurent Vivier <vivierl@frecb07144.(none)>
> > >
> > > This patch allows to define where is connected the CDROM device (bus,
> > > unit).
> > > It extends the "-cdrom" syntax to add these paramaters:
> > >
> > >      -cdrom file[,if=type][,bus=n][,unit=m]
> > >
> > >  where "type" defines the interface (by default, "ide")
> > >        "n" defines the bus number (by default 1)
> > >        "m" defines the unit number (by default 0)
> >
> >
> > Having a separately named arg just for CDROMs was always rather odd/unhelpful.
> > I'd suggest that we leave all the -hda,hdb,hdc,-cdrom,-fda,-fdb etc unchanged
> > and use the -disk for setting up all types of disks, floppys, cdroms, etc. It
> > would just require one extra field for the -disk arg:
> 
> Sounds logical and I thought this was the plan. I also wouldn't mind
> having -sda, -sdb... following the intuitive naming based on linux
> /dev, but IIRC there were some people on the list who didn't like this
> idea. (I know /dev/sda doesn't have to be an SCSI disk on some recent
> systems, but it's still the most intuitive name for most users).

But it won't hold in future, and on non-Linux systems. A -disk parameter
with backward compatibility aliases sounds good to me.


Thiemo