All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <ddaney@avtrex.com>
Cc: linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: Add len and addr validation for MAP_FIXED mappings.
Date: Mon, 29 Oct 2007 17:51:27 +0000	[thread overview]
Message-ID: <20071029175127.GC3953@linux-mips.org> (raw)
In-Reply-To: <472427CC.4000406@avtrex.com>

On Sat, Oct 27, 2007 at 11:10:20PM -0700, David Daney wrote:

> mmap with MAP_FIXED was not validating the addr and len parameters.
> This leads to the failure of GCC's gcc.c-torture/execute/loop-2[fg].c
> testcases when using the o32 ABI on a 64 bit kernel.
> 
> These testcases try to mmap 65536 bytes at 0x7fff8000 and then access
> all the memory.  In 2.6.18 and 2.6.23.1 (and likely other versions as
> well) the kernel maps the requested memory, but since half of it is
> above 0x80000000 a SIGBUS is generated when it is accessed.
> 
> This patch moves the len validation above the MAP_FIXED processing so
> that it is always validated.  It also adds validation to the addr
> parameter for MAP_FIXED mappings.

Thanks, applied.

  Ralf

      reply	other threads:[~2007-10-29 17:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-28  6:10 [PATCH] MIPS: Add len and addr validation for MAP_FIXED mappings David Daney
2007-10-29 17:51 ` Ralf Baechle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071029175127.GC3953@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=ddaney@avtrex.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.