From: Frans Pop <elendil@planet.nl>
To: Ingo Molnar <mingo@elte.hu>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Chuck Ebbert <cebbert@redhat.com>, Greg KH <greg@kroah.com>,
stable@kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [stable] 2.6.23 regression: top displaying 9999% CPU usage
Date: Mon, 29 Oct 2007 22:22:41 +0100 [thread overview]
Message-ID: <200710292222.42688.elendil@planet.nl> (raw)
In-Reply-To: <20071029204116.GA13026@elte.hu>
On Monday 29 October 2007, Ingo Molnar wrote:
> * Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> > > - return clock_t_to_cputime(utime);
> > > + p->prev_utime = max(p->prev_utime, clock_t_to_cputime(utime));
> > > + return p->prev_utime;
> > > }
> >
> > [...]
> >
> > I dont think it will work. It will make utime monotic, but stime can
> > still decrease. For example let sum_exec_runtime increase by a tiny
> > little bit while utime will get a full additional tick. stime is
> > sum-utime. So stime can still go backwards. So I think that we need
> > this kind of logic for stime as well, no?
>
> yeah, probably. Peter?
Yes, definitely :-)
With this patch stime is still all over the place.
Oct 29 22:12:39 314 64
Oct 29 22:12:40 392 68
Oct 29 22:12:41 408 67 <--
Oct 29 22:12:42 410 67
Oct 29 22:12:43 416 68
Oct 29 22:12:44 420 68
Oct 29 22:12:45 424 68
Oct 29 22:12:46 426 68
Oct 29 22:12:47 430 70
Oct 29 22:12:48 430 70
Oct 29 22:12:49 430 70
Oct 29 22:12:50 432 68 <--
Oct 29 22:12:51 432 69
Oct 29 22:12:52 432 69
Oct 29 22:12:53 432 69
Oct 29 22:12:54 432 69
Oct 29 22:12:55 432 69
Oct 29 22:12:56 433 70
Oct 29 22:12:57 434 69 <--
Oct 29 22:12:58 443 71
utime looks OK now, though I'd like to test it a bit more (when stime is
fixed too) before giving a final verdict on that.
next prev parent reply other threads:[~2007-10-29 21:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 20:31 2.6.23 regression: top displaying 9999% CPU usage Frans Pop
2007-10-12 21:22 ` [stable] " Greg KH
2007-10-13 7:53 ` Frans Pop
2007-10-14 20:36 ` Christian Borntraeger
2007-10-16 8:29 ` Christian Borntraeger
2007-10-16 9:30 ` Balbir Singh
2007-10-16 10:11 ` Frans Pop
2007-10-16 10:38 ` Balbir Singh
2007-10-16 10:34 ` Christian Borntraeger
2007-10-16 12:59 ` Balbir Singh
2007-10-29 12:05 ` Frans Pop
2007-10-29 12:31 ` Balbir Singh
2007-10-29 20:04 ` Ingo Molnar
2007-10-29 20:33 ` Christian Borntraeger
2007-10-29 20:41 ` Ingo Molnar
2007-10-29 21:11 ` Peter Zijlstra
2007-10-29 21:22 ` Frans Pop [this message]
2007-10-29 21:43 ` Balbir Singh
2007-10-29 23:19 ` Frans Pop
2007-10-29 23:22 ` Ingo Molnar
2007-10-30 20:22 ` Otavio Salvador
2007-10-29 23:24 ` Balbir Singh
2007-10-30 5:56 ` Christian Borntraeger
2007-10-30 6:00 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710292222.42688.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cebbert@redhat.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.