All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] standardising boolean variables in drivers/net (first
Date: Tue, 30 Oct 2007 12:17:12 +0000	[thread overview]
Message-ID: <20071030121712.GA26163@ghostprotocols.net> (raw)
In-Reply-To: <af42259d0710300134h63515753i6bcdad897a6296c3@mail.gmail.com>

Em Tue, Oct 30, 2007 at 07:34:04PM +1100, Lucas Woods escreveu:
> First patch here, be gentle, please let me know if I've made a mess of this :)
> 
> 
> Phase 1 standardised boolean variables in drivers/net
> 
> --
> diff --git a/drivers/net/ipg.h b/drivers/net/ipg.h
> index d5d092c..f67b29b 100644
> --- a/drivers/net/ipg.h
> +++ b/drivers/net/ipg.h
> @@ -491,37 +491,37 @@ enum ipg_regs {
>   */
> 
>  /* Miscellaneous Constants. */
> -#define   TRUE  1
> -#define   FALSE 0
> +#define   true  1
> +#define   false 0

You don't need to define 'true' and 'false', they are already defined in
include/linux/stddef.h

- Arnaldo

  parent reply	other threads:[~2007-10-30 12:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-30  8:34 [patch] standardising boolean variables in drivers/net (first phase) Lucas Woods
2007-10-30  8:40 ` [patch] standardising boolean variables in drivers/net (first Robert P. J. Day
2007-10-30 12:17 ` Arnaldo Carvalho de Melo [this message]
2007-10-30 14:30 ` Richard Knutsson
2007-10-30 14:52 ` Richard Knutsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071030121712.GA26163@ghostprotocols.net \
    --to=acme@ghostprotocols.net \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.