From: Andrew Morton <akpm@linux-foundation.org>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: mikael.starvik@axis.com, jesper.nilsson@axis.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/16] CRIS architecture: Correct compile errors
Date: Tue, 30 Oct 2007 15:14:06 -0700 [thread overview]
Message-ID: <20071030151406.9182c9fb.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071030093031.GH11960@axis.com>
On Tue, 30 Oct 2007 10:30:31 +0100
Jesper Nilsson <jesper.nilsson@axis.com> wrote:
> Include file linux/compiler.h is needed for 'likely'.
>
> Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
>
> ---
> atomic.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -urBb -X /h/jespern/.exclude_files clean_linux-2.6.23/include/asm-cris/atomic.h linux-2.6.23/include/asm-cris/atomic.h
> --- clean_linux-2.6.23/include/asm-cris/atomic.h 2007-10-09 22:31:38.000000000 +0200
> +++ linux-2.6.23/include/asm-cris/atomic.h 2007-10-22 10:32:54.000000000 +0200
> @@ -5,6 +5,7 @@
>
> #include <asm/system.h>
> #include <asm/arch/atomic.h>
> +#include <linux/compiler.h>
>
> /*
> * Atomic operations that C can't guarantee us. Useful for
> /^JN - Jesper Nilsson
> --
We conventionally include the <linux/...> headers before the <asm/...>
headers, with a single blank line between them. So:
#ifndef __ASM_CRIS_ATOMIC__
#define __ASM_CRIS_ATOMIC__
#include <linux/compiler.h>
#include <asm/system.h>
#include <asm/arch/atomic.h>
/*
prev parent reply other threads:[~2007-10-30 22:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 9:30 [PATCH 5/16] CRIS architecture: Correct compile errors Jesper Nilsson
2007-10-30 22:14 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030151406.9182c9fb.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jesper.nilsson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikael.starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.