[U-Boot-Users] [PATCH 1/2] PPC4xx: Cosmetic changes

[Stefan Roese <sr@denx.de>]

Hi Larry,

On Tuesday 30 October 2007, Larry Johnson wrote:
> Signed-off-by: Larry Johnson <lrj@acm.org>
> ---
>
> common/miiphyutil.c |  141++++++++++++++++++++++++--------------------------
> cpu/ppc4xx/miiphy.c |   58 +++++++--------------
> include/miiphy.h    |   92 +++++++++++++++------------------
> 3 files changed, 130 insertions(+), 161 deletions(-)

It is a little problematic, if you combine patches for a "common" networking 
file like common/miiphyutil.c and board/platform specific code in one patch. 
This is because one should get picked up by the networking custodian (Ben 
Warren) and the other by myself.

I see that both changes belong together, but you should nevertheless split 
them up into separate patches.

Same holds for the next patch of course too.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================