From: Len Brown <lenb@kernel.org>
To: Richard Knutsson <ricknu-0@student.ltu.se>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] acpi: 'acpi_gbl_system_awake_and_running' is no longer used, only assigned.
Date: Tue, 30 Oct 2007 22:33:20 -0400 [thread overview]
Message-ID: <200710302233.20440.lenb@kernel.org> (raw)
In-Reply-To: <20071030104750.30935.5409.sendpatchset@thinktank.campus.ltu.se>
Bob reports that this is used in a pending version of ACPICA,
so we'll leave the code alone.
thanks,
-Len
On Tuesday 30 October 2007 06:54, Richard Knutsson wrote:
> 'acpi_gbl_system_awake_and_running' is no longer used, only assigned.
>
> Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
> ---
> Diffed against linus-git
> Checked with script/checkpatch.pl
>
> drivers/acpi/hardware/hwsleep.c | 5 -----
> drivers/acpi/utilities/utglobal.c | 1 -
> include/acpi/acglobal.h | 1 -
> 3 files changed, 7 deletions(-)
>
>
> diff --git a/drivers/acpi/hardware/hwsleep.c b/drivers/acpi/hardware/hwsleep.c
> index 81b2484..e020e50 100644
> --- a/drivers/acpi/hardware/hwsleep.c
> +++ b/drivers/acpi/hardware/hwsleep.c
> @@ -300,8 +300,6 @@ acpi_status asmlinkage acpi_enter_sleep_state(u8 sleep_state)
> return_ACPI_STATUS(status);
> }
>
> - acpi_gbl_system_awake_and_running = FALSE;
> -
> status = acpi_hw_enable_all_wakeup_gpes();
> if (ACPI_FAILURE(status)) {
> return_ACPI_STATUS(status);
> @@ -446,7 +444,6 @@ acpi_status asmlinkage acpi_enter_sleep_state_s4bios(void)
> if (ACPI_FAILURE(status)) {
> return_ACPI_STATUS(status);
> }
> - acpi_gbl_system_awake_and_running = FALSE;
>
> status = acpi_hw_enable_all_wakeup_gpes();
> if (ACPI_FAILURE(status)) {
> @@ -587,8 +584,6 @@ acpi_status acpi_leave_sleep_state(u8 sleep_state)
> }
> /* TBD: _WAK "sometimes" returns stuff - do we want to look at it? */
>
> - acpi_gbl_system_awake_and_running = TRUE;
> -
> /* Enable power button */
>
> (void)
> diff --git a/drivers/acpi/utilities/utglobal.c b/drivers/acpi/utilities/utglobal.c
> index 93ea829..f2ba315 100644
> --- a/drivers/acpi/utilities/utglobal.c
> +++ b/drivers/acpi/utilities/utglobal.c
> @@ -709,7 +709,6 @@ void acpi_ut_init_globals(void)
> /* Hardware oriented */
>
> acpi_gbl_events_initialized = FALSE;
> - acpi_gbl_system_awake_and_running = TRUE;
>
> /* Namespace */
>
> diff --git a/include/acpi/acglobal.h b/include/acpi/acglobal.h
> index 347a911..ae0fc0a 100644
> --- a/include/acpi/acglobal.h
> +++ b/include/acpi/acglobal.h
> @@ -236,7 +236,6 @@ ACPI_EXTERN u8 acpi_gbl_step_to_next_call;
> ACPI_EXTERN u8 acpi_gbl_acpi_hardware_present;
> ACPI_EXTERN u8 acpi_gbl_global_lock_present;
> ACPI_EXTERN u8 acpi_gbl_events_initialized;
> -ACPI_EXTERN u8 acpi_gbl_system_awake_and_running;
>
> extern u8 acpi_gbl_shutdown;
> extern u32 acpi_gbl_startup_flags;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
prev parent reply other threads:[~2007-10-31 2:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 10:54 [PATCH] acpi: 'acpi_gbl_system_awake_and_running' is no longer used, only assigned Richard Knutsson
2007-10-31 2:33 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710302233.20440.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricknu-0@student.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.