From: David Gibson <david@gibson.dropbear.id.au>
To: Valentine Barshak <vbarshak@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/4] PowerPC: 440GRx Rainier DTS.
Date: Wed, 31 Oct 2007 10:08:05 +1100 [thread overview]
Message-ID: <20071030230805.GC2784@localhost.localdomain> (raw)
In-Reply-To: <20071030165650.GA22107@ru.mvista.com>
On Tue, Oct 30, 2007 at 07:56:50PM +0300, Valentine Barshak wrote:
> PowerPC 440GRx Rainier DTS.
[snip]
> + SDRAM0: sdram {
> + device_type = "memory-controller";
How many times do we need to say it...
Don't make up random device_type values. This does not belong here.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-10-30 23:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 16:45 [PATCH 0/4] PowerPC: 440GRx Rainier board support Valentine Barshak
2007-10-30 16:56 ` [PATCH 1/4] PowerPC: 440GRx Rainier bootwrapper Valentine Barshak
2007-10-30 16:56 ` [PATCH 2/4] PowerPC: 440GRx Rainier DTS Valentine Barshak
2007-10-30 23:08 ` David Gibson [this message]
2007-10-31 1:56 ` Olof Johansson
2007-10-31 2:09 ` Josh Boyer
2007-10-31 2:56 ` David Gibson
2007-10-31 12:26 ` Valentine Barshak
2007-10-30 16:57 ` [PATCH 3/4] PowerPC: 440GRx Rainier board support Valentine Barshak
2007-10-30 19:59 ` Arnd Bergmann
2007-10-31 3:11 ` Stephen Rothwell
2007-10-31 12:23 ` Valentine Barshak
2007-10-30 17:00 ` [PATCH 4/4] PowerPC: 440GRx Rainier default config Valentine Barshak
2007-10-30 18:17 ` [PATCH 0/4] PowerPC: 440GRx Rainier board support Josh Boyer
2007-10-30 18:31 ` Valentine Barshak
2007-10-30 20:16 ` Josh Boyer
2007-10-31 12:21 ` Valentine Barshak
2007-10-31 12:59 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030230805.GC2784@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=vbarshak@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.