From: David Miller <davem@davemloft.net>
To: jens.axboe@oracle.com
Cc: netdev@vger.kernel.org, herbert@gondor.apana.org.au,
rusty@rustcorp.com.au
Subject: Re: [PATCH]: Fix networking scatterlist regressions.
Date: Wed, 31 Oct 2007 02:26:43 -0700 (PDT) [thread overview]
Message-ID: <20071031.022643.118035583.davem@davemloft.net> (raw)
In-Reply-To: <20071031081428.GF5059@kernel.dk>
From: Jens Axboe <jens.axboe@oracle.com>
Date: Wed, 31 Oct 2007 09:14:28 +0100
> Subject: [PATCH] [SG] Get rid of __sg_mark_end()
>
> sg_mark_end() overwrites the page_link information, but all users want
> __sg_mark_end() behaviour where we just set the end bit. That is the most
> natural way to use the sg list, since you'll fill it in and then mark the
> end point.
>
> So change sg_mark_end() to only set the termination bit. Add a sg_magic
> debug check as well, and clear a chain pointer if it is set.
>
> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
It doesn't build. I suspect there is something else in your tree
that is necessary for this patch to work on it's own.
davem@sunset:~/src/GIT/net-2.6$ patch -p1 <diff
patching file block/ll_rw_blk.c
patching file drivers/scsi/scsi_lib.c
patching file include/linux/scatterlist.h
Hunk #2 succeeded at 242 (offset 22 lines).
patching file net/core/skbuff.c
patching file net/ipv4/tcp_ipv4.c
patching file net/ipv6/tcp_ipv6.c
patching file net/rxrpc/rxkad.c
patching file net/sunrpc/auth_gss/gss_krb5_crypto.c
...
CC init/main.o
In file included from include/asm/dma-mapping.h:4,
from include/linux/dma-mapping.h:52,
from include/asm/sbus.h:9,
from include/asm/dma.h:14,
from include/linux/bootmem.h:8,
from init/main.c:26:
include/linux/scatterlist.h: In function 'sg_init_one':
include/linux/scatterlist.h:228: error: too many arguments to function 'sg_mark_end'
make[1]: *** [init/main.o] Error 1
make: *** [init] Error 2
next prev parent reply other threads:[~2007-10-31 9:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 3:40 [PATCH]: Fix networking scatterlist regressions David Miller
2007-10-31 6:06 ` Rusty Russell
2007-10-31 6:44 ` David Miller
2007-10-31 7:32 ` Jens Axboe
2007-10-31 7:43 ` David Miller
2007-10-31 7:47 ` Jens Axboe
2007-10-31 7:46 ` Jens Axboe
2007-10-31 7:58 ` David Miller
2007-10-31 8:01 ` Jens Axboe
2007-10-31 8:08 ` David Miller
2007-10-31 8:08 ` Jens Axboe
2007-10-31 8:14 ` Jens Axboe
2007-10-31 9:26 ` David Miller [this message]
2007-10-31 9:29 ` Jens Axboe
2007-10-31 13:45 ` Herbert Xu
2007-10-31 13:46 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071031.022643.118035583.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jens.axboe@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.