From: Andrew Morton <akpm@linux-foundation.org>
To: Pierre Peiffer <pierre.peiffer@bull.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.23-mm1] Change the ida/idr_pre_get() return value to follow the kernel convention
Date: Wed, 31 Oct 2007 03:14:53 -0700 [thread overview]
Message-ID: <20071031031453.ae873860.akpm@linux-foundation.org> (raw)
In-Reply-To: <472853A8.8040308@bull.net>
On Wed, 31 Oct 2007 11:06:32 +0100 Pierre Peiffer <pierre.peiffer@bull.net> wrote:
> >
> > Storage classes which need to allcoate memory at insertion time are hard:
> > radix_tree_preload() gets it right in terms of robustness, but it's an
> > awful lot of fuss.
> >
> > IDR gets it all wrong and compounds the problem by implementing internal
> > locking. It shouldn't have done that: storage code like this should use
> > only caller-provided locking.
>
> Ok, but for that, I prefer to let the IDR maintainers see what they can do,
> because I'm not familiar at all with the IDR implementation and can not focus on
> that now.
Jim isn't very active nowadays
> So do you think that just providing a new API (something like
> idr_pre_allocate(), as you say above) would be better than nothing ?
> Or we just leave the code as is for now ?
I guess we can leave it as-is if the present interface isn't actually
causing you guys any problems.
prev parent reply other threads:[~2007-10-31 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 16:13 [PATCH 2.6.23-mm1] Change the ida/idr_pre_get() return value to follow the kernel convention Pierre Peiffer
2007-10-30 17:33 ` Andrew Morton
2007-10-31 10:06 ` Pierre Peiffer
2007-10-31 10:14 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071031031453.ae873860.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre.peiffer@bull.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.