All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 13/25] Share TFRC feedback types struct via ccid34_lib
Date: Wed, 31 Oct 2007 09:59:14 +0000	[thread overview]
Message-ID: <200710310959.15075@strip-the-willow> (raw)

I have a suggestion regarding types, names, and things shared between
CCID3 and CCID4 via dccp_tfrc_lib:

I think it would be best to name all such shared structures / names,
when they are to appear in the dccp_tfrc_lib, as `tfrc_xxx' instead of
`ccid34_xxx'

For example,

enum tfrc_fback_type {
// ...
};
 
instead of:

|  enum ccid34_fback_type {
|  + FBACK_NONE = 0,
|  + FBACK_INITIAL,
|  + FBACK_PERIODIC,
|  + FBACK_PARAM_CHANGE
|  +};

There are no mechanisms other than TFRC (current work builds around TFRC, rather than entirely new schemes)
so I think that this naming scheme is safe; and it would be consistent throughout the library.

I'd hope that Arnaldo and Ian add their take if they disagree or have other suggestions.

             reply	other threads:[~2007-10-31  9:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-31  9:59 Gerrit Renker [this message]
2007-10-31 11:55 ` [PATCH 13/25] Share TFRC feedback types struct via ccid34_lib Arnaldo Carvalho de Melo
2007-10-31 13:15 ` Gerrit Renker
2007-10-31 22:21 ` Łeandro Sales
2007-11-01  0:31 ` [PATCH 13/25] Share TFRC feedback types struct via tfrc_ccids Leandro
2007-11-01 12:29 ` Tommi Saviranta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710310959.15075@strip-the-willow \
    --to=gerrit@erg.abdn.ac.uk \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.