All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Tony Luck <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] Driver core: remove class_device_*_bin_file
Date: Wed, 31 Oct 2007 11:44:33 -0700	[thread overview]
Message-ID: <20071031184433.GA6654@suse.de> (raw)
In-Reply-To: <12c511ca0710311026v39a91e61o448b340f413e08c0@mail.gmail.com>

On Wed, Oct 31, 2007 at 10:26:37AM -0700, Tony Luck wrote:
> On 10/30/07, Greg Kroah-Hartman <gregkh@suse.de> wrote:
> > These functions are not used by anyone, so remove them from the tree.
> 
> /me coughs ...
> 
>   CC      drivers/pci/probe.o
> drivers/pci/probe.c: In function `pci_create_legacy_files':
> drivers/pci/probe.c:57: error: implicit declaration of function
> `class_device_create_bin_file'
> drivers/pci/probe.c: In function `pci_remove_legacy_files':
> drivers/pci/probe.c:72: error: implicit declaration of function
> `class_device_remove_bin_file'

Oh crap, very sorry about this, I'll send a revert-patch to Linus in a
bit.

I didn't see this as I have patches in my tree that change these calls
to use struct device instead of struct class_device, but that's not
going to Linus until 2.6.25.

thanks,

greg k-h

      reply	other threads:[~2007-10-31 18:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-31  5:09 [GIT PATCH] driver core fixes for 2.6.24-rc1 Greg KH
2007-10-31  5:11 ` [PATCH 1/6] Driver core: remove class_device_*_bin_file Greg Kroah-Hartman
2007-10-31  5:11   ` [PATCH 2/6] kobject: check for duplicate names in kobject_rename Greg Kroah-Hartman
2007-10-31  5:11     ` [PATCH 3/6] sysfs: make sysfs_{get,put}_active() static Greg Kroah-Hartman
2007-10-31  5:11       ` [PATCH 4/6] Driver Core: fix bug in device_rename() for SYSFS_DEPRECATED=y Greg Kroah-Hartman
2007-10-31  5:11         ` [PATCH 5/6] fix typo in SubmittingPatches Greg Kroah-Hartman
2007-10-31  5:11           ` [PATCH 6/6] add SubmittingPatches to Documentation/ja_JP Greg Kroah-Hartman
2007-10-31  9:17           ` [PATCH 5/6] fix typo in SubmittingPatches Andy Whitcroft
2007-10-31 17:26   ` [PATCH 1/6] Driver core: remove class_device_*_bin_file Tony Luck
2007-10-31 18:44     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071031184433.GA6654@suse.de \
    --to=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.