From: Alejandro Martinez Ruiz <alex@flawedcode.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: martin f krafft <madduck@madduck.net>,
git discussion list <git@vger.kernel.org>
Subject: Re: unmerging feature branches
Date: Wed, 31 Oct 2007 22:16:58 +0100 [thread overview]
Message-ID: <20071031211658.GA5430@inspiron> (raw)
In-Reply-To: <alpine.LFD.0.999.0710231026011.30120@woody.linux-foundation.org>
On Tue 23 Oct 2007, 10:40, Linus Torvalds wrote:
>
> So a "revert" is fundamentally different from a "undo". Most of the time
>
> [cut]
>
> So sometimes the behaviour of "git revert" will be exactly what people
> expected and wanted ("good, I'll never get that commit again when I pull,
> because I told git that I don't want that commit"), and sometimes it will
> _not_ be what people expected and wanted ("oh, I didn't get that commit,
> even though I was now ready for it - because I had reverted it back when I
> was *not* ready for it").
>
> See? The logic is exactly the same in both cases, but one was good, the
> other bad, and the only difference was really the mindset of the user.
>
> A tool can't ever get "mindset of the user" differences right. At least
> not until we add the "esp option" ;)
>
> So I really don't want to push this as a problem or deficiency, I think
> it's a good thing. But it's a good thing only when people are *aware* of
> what "revert" really means.
So how about an "undo" command or a switch for revert with a special
meaning like "hey, this one is a nice commit, but it ain't ready yet,
I'd like you to ignore I ever committed the thing when merging or
rebasing again, thanks"?
Alex
next prev parent reply other threads:[~2007-10-31 21:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 15:24 unmerging feature branches martin f krafft
2007-10-23 16:19 ` Matthieu Moy
2007-10-23 16:50 ` Linus Torvalds
2007-10-23 17:16 ` martin f krafft
2007-10-23 17:40 ` Linus Torvalds
2007-10-23 18:08 ` martin f krafft
2007-10-23 18:24 ` Linus Torvalds
2007-10-23 19:17 ` martin f krafft
2007-10-23 19:38 ` Linus Torvalds
2007-10-23 19:46 ` Linus Torvalds
2007-10-31 21:16 ` Alejandro Martinez Ruiz [this message]
2007-10-31 21:27 ` martin f krafft
2007-10-31 21:34 ` Linus Torvalds
2007-10-23 19:33 ` Junio C Hamano
2007-10-23 19:49 ` Linus Torvalds
2007-10-23 20:33 ` [PATCH] revert/cherry-pick: work on merge commits as well Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071031211658.GA5430@inspiron \
--to=alex@flawedcode.org \
--cc=git@vger.kernel.org \
--cc=madduck@madduck.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.