All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven King <sfking@fdwdc.com>
To: linux-kernel@vger.kernel.org
Cc: Greg KH <greg@kroah.com>, linux-usb-devel@lists.sourceforge.net
Subject: Re: ti_usb_3410_5052 breakage in 2.6.24-rc1
Date: Thu, 1 Nov 2007 03:25:54 -0700	[thread overview]
Message-ID: <200711010325.55147.sfking@fdwdc.com> (raw)
In-Reply-To: <20071101061954.GA11303@kroah.com>

Per a suggestion by David Brownwell, rebuilt with CONFIG_USB_DEBUG enabled and 
loading usbserial and ti_usb_3410_5052 with debug=1, I see in 'dmesg'

'drivers/usb/serial/usb-serial.c: wrong number of endpoints'

 which is pretty much what I expected, throwing some more printk's in 
usb-serial gives:

drivers/usb/serial/usb-serial.c: num_interrupt_in = 0, expected 1
drivers/usb/serial/usb-serial.c: num_interrupt_out = 0, expected 0
drivers/usb/serial/usb-serial.c: num_bulk_in = 0, expected 1
drivers/usb/serial/usb-serial.c: num_bulk_out = 1, expected 1

Okay, so
---

Changing num_interrupt_in and num_bulk_in from 1 to NUM_DONT_CARE makes 
ti_usb_3410_5052 work again, but is it the right thing to do?

Signed-off-by: Steven King <sfking@fdwdc.com>
---
 ti_usb_3410_5052.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/serial/ti_usb_3410_5052.c 
b/drivers/usb/serial/ti_usb_3410_5052.c
index 1f01494..337f5ce 100644
--- a/drivers/usb/serial/ti_usb_3410_5052.c
+++ b/drivers/usb/serial/ti_usb_3410_5052.c
@@ -264,8 +264,8 @@ static struct usb_serial_driver ti_1port_device = {
 	.description		= "TI USB 3410 1 port adapter",
 	.usb_driver		= &ti_usb_driver,
 	.id_table		= ti_id_table_3410,
-	.num_interrupt_in	= 1,
-	.num_bulk_in		= 1,
+	.num_interrupt_in	= NUM_DONT_CARE,
+	.num_bulk_in		= NUM_DONT_CARE,
 	.num_bulk_out		= 1,
 	.num_ports		= 1,
 	.attach			= ti_startup,

  parent reply	other threads:[~2007-11-01 10:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-01  5:25 ti_usb_3410_5052 breakage in 2.6.24-rc1 Steven King
2007-11-01  6:19 ` Greg KH
2007-11-01  6:34   ` Steven King
2007-11-01 10:25   ` Steven King [this message]
2007-11-01 14:51     ` [linux-usb-devel] " Alan Stern
2007-11-01 17:31       ` Steven King
2007-11-01 20:08         ` Alan Stern
2007-11-01 14:47 ` Alan Stern
2007-11-01 16:19   ` Steven King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711010325.55147.sfking@fdwdc.com \
    --to=sfking@fdwdc.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.