From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: aim7 -30% regression in 2.6.24-rc1
Date: Thu, 1 Nov 2007 09:58:24 +0100 [thread overview]
Message-ID: <20071101085824.GA12721@elte.hu> (raw)
In-Reply-To: <1193826639.27652.113.camel@twins>
* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> static int one_hundred = 100;
> +static int int_max = INT_MAX;
>
> /* this is needed for the proc_dointvec_minmax for [fs_]overflow UID and GID */
> static int maxolduid = 65535;
> @@ -239,7 +240,10 @@ static struct ctl_table kern_table[] = {
> .data = &sysctl_sched_nr_latency,
> .maxlen = sizeof(unsigned int),
> .mode = 0644,
> - .proc_handler = &proc_dointvec,
> + .proc_handler = &proc_dointvec_minmax,
> + .strategy = &sysctl_intvec,
> + .extra1 = &one,
> + .extra2 = &int_max,
could we instead justmake sched_nr_latency non-tunable, and recalculate
it from the sysctl handler whenever sched_latency or
sched_min_granularity changes? That would avoid not only the division by
zero bug but also other out-of-spec tunings.
Ingo
next prev parent reply other threads:[~2007-11-01 8:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 9:43 aim7 -30% regression in 2.6.24-rc1 Zhang, Yanmin
2007-10-26 9:53 ` Peter Zijlstra
2007-10-29 0:15 ` Zhang, Yanmin
2007-10-26 11:23 ` Ingo Molnar
2007-10-29 2:22 ` Zhang, Yanmin
2007-10-29 9:37 ` Zhang, Yanmin
2007-10-30 2:12 ` Zhang, Yanmin
2007-10-30 7:26 ` Ingo Molnar
2007-10-30 8:36 ` Zhang, Yanmin
2007-10-31 9:57 ` Zhang, Yanmin
2007-10-31 10:30 ` Peter Zijlstra
2007-11-01 8:58 ` Ingo Molnar [this message]
[not found] ` <1193922687.27652.279.camel@twins>
[not found] ` <20071101150049.GB4044@elte.hu>
2007-11-01 15:29 ` Peter Zijlstra
2007-11-01 15:36 ` Ingo Molnar
2007-11-01 9:34 ` Zhang, Yanmin
2007-11-01 10:02 ` Cyrus Massoumi
2007-11-05 1:24 ` Zhang, Yanmin
2007-11-05 9:37 ` Cyrus Massoumi
2007-11-07 5:30 ` Zhang, Yanmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071101085824.GA12721@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.