From: akpm@linux-foundation.org
To: mm-commits@vger.kernel.org
Cc: jens.axboe@oracle.com
Subject: + crash-on-shutdown-unmount.patch added to -mm tree
Date: Thu, 01 Nov 2007 12:30:38 -0700 [thread overview]
Message-ID: <20071101193038.6E154432BDC@localhost> (raw)
The patch titled
crash on shutdown/unmount
has been added to the -mm tree. Its filename is
crash-on-shutdown-unmount.patch
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: crash on shutdown/unmount
From: Jens Axboe <jens.axboe@oracle.com>
On Wed, Oct 31 2007, Alistair John Strachan wrote:
> Hi Jens,
>
> I guessed from the oops that you might have an idea what's causing this oops
> on shutdown/unmount. The git version (describe), a screenshot showing the
> oops, a config, and dmesg for a booted kernel are available from:
>
> http://devzero.co.uk/~alistair/oops-20071031/
>
> I went back to -rc1 and it still happens there too. If you need any more
> information or want me to bisect it, please let me know.
Does this work for you?
index 54fd385..75c98d5 100644
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
block/ll_rw_blk.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff -puN block/ll_rw_blk.c~crash-on-shutdown-unmount block/ll_rw_blk.c
--- a/block/ll_rw_blk.c~crash-on-shutdown-unmount
+++ a/block/ll_rw_blk.c
@@ -3221,6 +3221,7 @@ static inline void __generic_make_reques
sector_t old_sector;
int ret, nr_sectors = bio_sectors(bio);
dev_t old_dev;
+ int err = -EIO;
might_sleep();
@@ -3248,7 +3249,7 @@ static inline void __generic_make_reques
bdevname(bio->bi_bdev, b),
(long long) bio->bi_sector);
end_io:
- bio_endio(bio, -EIO);
+ bio_endio(bio, err);
break;
}
@@ -3283,6 +3284,10 @@ end_io:
if (bio_check_eod(bio, nr_sectors))
goto end_io;
+ if (bio_empty_barrier(bio) && !q->prepare_flush_fn) {
+ err = -EOPNOTSUPP;
+ goto end_io;
+ }
ret = q->make_request_fn(q, bio);
} while (ret);
_
Patches currently in -mm which might be from jens.axboe@oracle.com are
origin.patch
scsi-early-detection-of-medium-not-present-updated.patch
git-block.patch
git-block-fixup.patch
crash-on-shutdown-unmount.patch
arch-um-drivers-ubd_kernc-a-warning-fix.patch
fix-versus-precedence-in-various-places.patch
fix-versus-precedence-in-various-places-checkpatch-fixes.patch
revoke-vs-git-block.patch
reiser4.patch
reply other threads:[~2007-11-01 19:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071101193038.6E154432BDC@localhost \
--to=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.