Re: [RFC] oom notifications via /dev/oom_notify

[Marcelo Tosatti <marcelo@kvack.org>]

On Wed, Oct 31, 2007 at 01:20:10PM -0400, Dave Jones wrote:
> On Tue, Oct 30, 2007 at 05:07:43PM -0400, Marcelo Tosatti wrote:
>  > +		case 13:
>  > +			filp->f_op = &oom_notify_fops;
>  > +			break;
> 
> Don't forget to add this to Documentation/devices.txt

Done.

>  > +	while (cpu < NR_CPUS) {
>  > +		struct vm_event_state *this = &per_cpu(vm_event_states, cpu);
>  > +
>  > +		cpu = next_cpu(cpu, *cpumask);
>  > +
>  > +		if (cpu < NR_CPUS)
>  > +			prefetch(&per_cpu(vm_event_states, cpu));
>  > +
>  > +		ret += this->event[vm_event];
>  > +	}
>  > +	return ret;
>  > +}
> 
> Is the prefetching worth it?

Taking into account that this is a generic function and as such any
member of this->event[] might be accessed, no... removed. 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>