From: Mike Hommey <mh@glandium.org>
To: Benoit SIGOURE <tsuna@lrde.epita.fr>
Cc: git list <git@vger.kernel.org>
Subject: Re: [PATCH] Mac OS X 10.5 does not require the OLD_ICONV flag set
Date: Fri, 2 Nov 2007 10:45:08 +0100 [thread overview]
Message-ID: <20071102094508.GA29828@glandium.org> (raw)
In-Reply-To: <B858412A-853A-4660-BA4B-F9751E4AAEAE@lrde.epita.fr>
On Fri, Nov 02, 2007 at 10:39:35AM +0100, Benoit SIGOURE <tsuna@lrde.epita.fr> wrote:
> On Nov 2, 2007, at 10:30 AM, Mike Hommey wrote:
>
> >On Fri, Nov 02, 2007 at 02:03:52AM -0700, Junio C Hamano
> ><gitster@pobox.com> wrote:
> >>Blake Ramsdell <blaker@gmail.com> writes:
> >>
> >>>Signed-off-by: Blake Ramsdell <blaker@gmail.com>
> >>>---
> >>> Makefile | 4 +++-
> >>> 1 files changed, 3 insertions(+), 1 deletions(-)
> >>>
> >>>diff --git a/Makefile b/Makefile
> >>>index 71479a2..5d83756 100644
> >>>--- a/Makefile
> >>>+++ b/Makefile
> >>>@@ -401,7 +401,9 @@ endif
> >>> ifeq ($(uname_S),Darwin)
> >>> NEEDS_SSL_WITH_CRYPTO = YesPlease
> >>> NEEDS_LIBICONV = YesPlease
> >>>- OLD_ICONV = UnfortunatelyYes
> >>>+ ifneq ($(uname_R),9.0.0)
> >>>+ OLD_ICONV = UnfortunatelyYes
> >>>+ endif
> >>> NO_STRLCPY = YesPlease
> >>> NO_MEMMEM = YesPlease
> >>> endif
> >>
> >>I do not have an access to a Darwin box, but do you mean 10.5
> >>gives 9.0.0 as uname_R?
> >
> >Be it that or not, it looks wrong to me to check the Darwin version to
> >know what to use. Do you rely on the Linux kernel version to know
> >whether
> >iconv is present ?
>
> It's very different, on OSX you don't change your own kernel as you
> want, the kernel isn't a standalone component, it comes packaged with
> the entire system of MacOSX. When you do an update to 10.5 (aka
> Leopard) you will have a new version of iconv so you're guaranteed
> that someone with 10.5 has a system-wide iconv that is not OLD_ICONV.
The fact is you can also use Darwin without OSX...
Mike
next prev parent reply other threads:[~2007-11-02 9:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 2:38 [PATCH] Mac OS X 10.5 does not require the OLD_ICONV flag set Blake Ramsdell
2007-11-02 2:38 ` [PATCH] Fixed a gcc 4.0.1 complaint about an uninitialized variable Blake Ramsdell
2007-11-02 5:37 ` Junio C Hamano
2007-11-02 9:03 ` [PATCH] Mac OS X 10.5 does not require the OLD_ICONV flag set Junio C Hamano
2007-11-02 9:20 ` Blake Ramsdell
2007-11-02 9:30 ` Mike Hommey
2007-11-02 9:39 ` Benoit SIGOURE
2007-11-02 9:45 ` Mike Hommey [this message]
2007-11-02 10:19 ` David Symonds
2007-11-02 10:33 ` Junio C Hamano
2007-11-02 11:23 ` David Symonds
2007-11-02 20:03 ` Blake Ramsdell
2007-11-03 0:00 ` [PATCH] Removed OLD_ICONV in favor of checking _LIBICONV_VERSION directly Blake Ramsdell
2007-11-03 0:07 ` Junio C Hamano
2007-11-03 0:21 ` Blake Ramsdell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071102094508.GA29828@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=tsuna@lrde.epita.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.