From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Christoph Egger" Subject: Re: xenfb: portability issue Date: Fri, 2 Nov 2007 11:54:27 +0200 Message-ID: <200711021054.27814.Christoph.Egger@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com, "Daniel P.Berrange" List-Id: xen-devel@lists.xenproject.org On Friday 02 November 2007 10:45:15 Keir Fraser wrote: > Actually I liked your suggestion better for this particular issue, so I > checked it in. I just tested changest 16306 and works fine with me. Thanks. Christoph > -- Keir > > On 2/11/07 09:28, "Christoph Egger" wrote: > > I'm testing John Levon's patch. > > > > On Friday 02 November 2007 10:19:08 Keir Fraser wrote: > >> I think John Levon's recent patch might fix this. I'm going to go > >> through and check in most or all of it I expect. > >> > >> -- Keir > >> > >> On 2/11/07 09:12, "Christoph Egger" wrote: > >>> Hi! > >>> > >>> Changeset 16250 is not portable. On BSD I get these build errors: > >>> > >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:19:25: error: > >>> linux/input.h: No such file or directory > >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c: In > >>> function 'xenfb_mouse_event': > >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: > >>> 'BTN_LEFT' undeclared (first use in this function) > >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: (Each > >>> undeclared identifier is reported only once > >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: for > >>> each function it appears in.) =2D-=20 AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Gesch=E4ftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplement=E4r: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Gesch=E4ftsf=FChrer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy