All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix delay accounting regression
Date: Sat, 3 Nov 2007 09:33:58 +0100	[thread overview]
Message-ID: <20071103083358.GE10760@elte.hu> (raw)
In-Reply-To: <20071102165559.GA5424@linux.vnet.ibm.com>


* Balbir Singh <balbir@linux.vnet.ibm.com> wrote:

> On Fri, Nov 02, 2007 at 04:53:58PM +0100, Ingo Molnar wrote:
> > 
> > * Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> > 
> > > Fix the delay accounting regression introduced by commit 
> > > 75d4ef16a6aa84f708188bada182315f80aab6fa. rq no longer has sched_info 
> > > data associated with it. task_struct sched_info structure is used by 
> > > delay accounting to provide back statistics to user space.
> > 
> > no, this really is broken code. sched_clock() is not a generally 
> > reliable time source so at a minimum the rq->clock fix i mentioned is 
> > needed. What user-space tools are utilizing delay-accounting by the way? 
> > We have most of this data available under SCHEDSTATS - how about 
> > consolidating CONFIG_TASK_DELAY_ACCT into CONFIG_SCHEDSTATS?
> > 
> > 	Ingo
> 
> Hi, Ingo,
> 
> How about this?

thanks, applied.

	Ingo

      reply	other threads:[~2007-11-03  8:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-02 14:22 [PATCH] Fix delay accounting regression Balbir Singh
2007-11-02 15:53 ` Ingo Molnar
2007-11-02 16:05   ` Guillaume Chazarain
2007-11-02 16:35   ` Balbir Singh
2007-11-02 16:55   ` Balbir Singh
2007-11-03  8:33     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071103083358.GE10760@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.