From: Pierre Habouzit <madcoder@debian.org>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: gitster@pobox.com, torvalds@linux-foundation.org, git@vger.kernel.org
Subject: Re: [PATCH 5/5] Migrate git-am.sh to use git-rev-parse --parseopt
Date: Sat, 03 Nov 2007 12:54:45 +0100 [thread overview]
Message-ID: <20071103115445.GA13417@artemis.corp> (raw)
In-Reply-To: <20071103095556.GB2853@steel.home>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On Sat, Nov 03, 2007 at 09:55:56AM +0000, Alex Riesen wrote:
> Pierre Habouzit, Fri, Nov 02, 2007 23:39:52 +0100:
> > diff --git a/git-am.sh b/git-am.sh
> > index 2514d07..e5ed6a7 100755
> > --- a/git-am.sh
> > +++ b/git-am.sh
> ....
> > - usage ;;
> > - *)
> > - break ;;
> > + -i|--interactive)
> > + interactive=t ;;
> > + -b|--binary)
> > + binary=t ;;
>
> Did you really have to change the indentation?
Well, I'm unsure what the standard is for git, I gladly use any
indentation, I don't really care. I assumed that it wasn't indented
before becauuse instead of -i|--interactive you had:
-i|--in|--int|....|--interactive which took a lot of space, as it
seemed to me that the case ".." in foo) esac construction in git had the
cases indented in most places. But I may be wrong.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-11-03 11:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 22:39 let's retry this based on git-rev-parse --parseopt Pierre Habouzit
2007-11-02 22:39 ` [PATCH 1/5] Add a parseopt mode to git-rev-parse to bring parse-options to shell scripts Pierre Habouzit
2007-11-02 22:39 ` [PATCH 2/5] Update git-sh-setup(1) to allow transparent use of git-rev-parse --parseopt Pierre Habouzit
2007-11-02 22:39 ` [PATCH 3/5] Migrate git-clean.sh to use " Pierre Habouzit
2007-11-02 22:39 ` [PATCH 4/5] Migrate git-clone " Pierre Habouzit
2007-11-02 22:39 ` [PATCH 5/5] Migrate git-am.sh " Pierre Habouzit
2007-11-03 9:55 ` Alex Riesen
2007-11-03 11:54 ` Pierre Habouzit [this message]
2007-11-03 12:05 ` Pierre Habouzit
2007-11-03 17:50 ` [PATCH 5/5 FIX SPACING] " Pierre Habouzit
2007-11-03 17:50 ` [PATCH 6/5] Migrate git-merge.sh " Pierre Habouzit
2007-11-03 17:50 ` [PATCH 8/5] Migrate git-instaweb.sh " Pierre Habouzit
2007-11-03 17:50 ` [PATCH 9/5] Migrate git-checkout.sh to use git-rev-parse --parseopt --keep-dashdash Pierre Habouzit
2007-11-03 17:50 ` [PATCH 10/5] Migrate git-quiltimport.sh to use git-rev-parse --parseopt Pierre Habouzit
2007-11-03 18:35 ` [PATCH 11/5] Migrate git-repack.sh " Pierre Habouzit
2007-11-04 7:44 ` [PATCH 9/5] Migrate git-checkout.sh to use git-rev-parse --parseopt --keep-dashdash Junio C Hamano
2007-11-04 9:03 ` Pierre Habouzit
2007-11-04 13:48 ` Johannes Schindelin
2007-11-04 14:18 ` Pierre Habouzit
2007-11-04 7:43 ` [PATCH 2/5] Update git-sh-setup(1) to allow transparent use of git-rev-parse --parseopt Junio C Hamano
2007-11-04 9:11 ` [UPDATED PATCH 3/5] " Pierre Habouzit
2007-11-04 9:11 ` [UPDATED PATCH 5/5] Migrate git-clone to use " Pierre Habouzit
2007-11-04 9:11 ` [UPDATED PATCH 9/5] Migrate git-checkout.sh to use git-rev-parse --parseopt --keep-dashdash Pierre Habouzit
2007-11-04 9:14 ` [PATCH 2/5] Update git-sh-setup(1) to allow transparent use of git-rev-parse --parseopt Pierre Habouzit
2007-11-04 9:15 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071103115445.GA13417@artemis.corp \
--to=madcoder@debian.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.