From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IoLM0-0002oL-GO
	for qemu-devel@nongnu.org; Sat, 03 Nov 2007 11:56:08 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IoLLz-0002np-Ap
	for qemu-devel@nongnu.org; Sat, 03 Nov 2007 11:56:07 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IoLLz-0002nm-8x
	for qemu-devel@nongnu.org; Sat, 03 Nov 2007 11:56:07 -0400
Received: from relay01.mx.bawue.net ([193.7.176.67])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1IoLLx-0000Hl-Mc
	for qemu-devel@nongnu.org; Sat, 03 Nov 2007 11:56:06 -0400
Date: Sat, 3 Nov 2007 15:56:00 +0000
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] Re: [PATCH] efault - add data type to
	put_user()/get_user()
Message-ID: <20071103155600.GC14756@networkno.de>
References: <1193869827.19343.38.camel@phantasm.home.enterpriseandprosperity.com>
	<1193870136.19343.43.camel@phantasm.home.enterpriseandprosperity.com>
	<1193870631.19343.51.camel@phantasm.home.enterpriseandprosperity.com>
	<1194045983.2168.17.camel@phantasm.home.enterpriseandprosperity.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1194045983.2168.17.camel@phantasm.home.enterpriseandprosperity.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thayne Harbaugh <thayne@c2.net>
Cc: qemu-devel <qemu-devel@nongnu.org>

Thayne Harbaugh wrote:
> 
> On Wed, 2007-10-31 at 16:44 -0600, Thayne Harbaugh wrote:
> > This patch updates get_user() and put_user() to take a third argument of
> > data type.  get_user() and put_user() use target address which are
> > target_ulong and don't reflect the data type pointed to in target
> > memory.
> > 
> > Simply casting the target_ulong to a type before passing to
> > get/put_user() is poor because target_ulong isn't always a simple cast
> > to a host type (consider 32 bit on 64 bit where address are either
> > extended or truncate).  Also, simple casting of the argument to
> > get/put_user() results in several warnings when target and long pointer
> > sizes don't match.
> > 
> > This patch has additional updates to fix places where get/put_user() are
> > already used.
> 
> This is an updated patch that doesn't conflict with the
> abi_long/abi_ulong changes from a couple weeks ago.

Still misses the sparc64 bits in linux-user/signal.c.


Thiemo