All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <stf_xl@wp.pl>
To: drbd-dev@lists.linbit.com
Subject: [Drbd-dev] don't memset null pointer
Date: Mon, 5 Nov 2007 13:04:49 +0100	[thread overview]
Message-ID: <200711051304.49960.stf_xl@wp.pl> (raw)

Hi, this is trivial fix for memset null pointer:

diff --git a/drbd/lru_cache.c b/drbd/lru_cache.c
index a3171b6..37ab276 100644
--- a/drbd/lru_cache.c
+++ b/drbd/lru_cache.c
@@ -57,8 +57,8 @@ struct lru_cache *lc_alloc(const char *name, unsigned int e_count,
 	bytes *= e_count;
 	bytes += sizeof(struct lru_cache);
 	lc     = vmalloc(bytes);
-	memset(lc, 0, bytes);
 	if (lc) {
+		memset(lc, 0, bytes);
 		INIT_LIST_HEAD(&lc->in_use);
 		INIT_LIST_HEAD(&lc->lru);
 		INIT_LIST_HEAD(&lc->free);

             reply	other threads:[~2007-11-05 12:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-05 12:04 Stanislaw Gruszka [this message]
2007-11-05 13:07 ` [Drbd-dev] don't memset null pointer Philipp Reisner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711051304.49960.stf_xl@wp.pl \
    --to=stf_xl@wp.pl \
    --cc=drbd-dev@lists.linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.