Re: [Qemu-devel] [PATCH] Add TPM support

[Thomas Bleher <ThomasBleher@gmx.de>]

[-- Attachment #1: Type: text/plain, Size: 2384 bytes --]

* Thomas Bleher <ThomasBleher@gmx.de> [2007-11-01 16:55]:
> * Thiemo Seufer <ths@networkno.de> [2007-10-31 17:14]:
> > Thomas Bleher wrote:
> > > * Thiemo Seufer <ths@networkno.de> [2007-10-31 13:54]:
> > > > Thomas Bleher wrote:
> > > > > --- /dev/null
> > > > > +++ b/hw/tpm.c
> > > > > @@ -0,0 +1,219 @@
> > > > > +/*
> > > > > + * TPM emulation
> > > > > + * Written by Thomas Bleher <ThomasBleher@gmx.de>.
> > > > > + *
> > > > > + * This driver emulates a TPM chip. TPM chips are quite complex, and a TPM
> > > > > + * emulator already exists, therefore this driver just connects to this
> > > > > + * emulator and forwards all the data. For the TPM emulator project, see
> > > > > + * http://tpm-emulator.berlios.de/
> > > > > + *
> > > > > + * The author does not own any TPM chip himself, so the Linux Kernel driver for
> > > > > + * Atmel TPM chips was taken as a reference. The code works fine with the Linux
> > > > > + * driver, but no tests have been done on other operating systems.
> > > > > + *
> > > > > + * Some structures are copied from the Linux Kernel source code.
> > > > > + */
> > > > 
> > > > So the License of this file is "GPL, Version 2"? The license should be
> > > > mentioned in the comment.
> > > 
> > > I think that the parts I copied are not copyrightable, as I only copied
> > > the two enums (I didn't copy any structures, the comment was wrong) and,
> > > modulo naming, I see no other way to implement this.
> > 
> > Ok, so the Kernel license isn't relevant here.
> > 
> > > So I would be willing to license this under a more liberal license, but
> > > to be on the safe side, GNU GPLv2 is the best choice.
> > 
> > I didn't intend to enforce GPL licensing, I just concluded from the
> > description that the patch would include substantial parts of kernel
> > source code. Since this isn't the case, feel free to choose your
> > preferred license for it.
> 
> Is there a preferred license for qemu? I see that the code as a whole is
> licensed under the GPLv2, but some code is under the LGPL or some BSD
> license. I'm willing to license it under whatever license suits qemu
> best.

Thiemo Seufer told me that GPLv2 is fine for qemu, therefore I'd like to
ask that this patch be included in qemu as I posted it (the second
version with the clarified GPLv2 license).

Thanks,
Thomas Bleher

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]