All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: David Miller <davem@davemloft.net>, Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org
Subject: [PATCH 4/7] sky2: dont change LED after autoneg
Date: Mon, 05 Nov 2007 15:52:11 -0800	[thread overview]
Message-ID: <20071105235340.143067950@linux-foundation.org> (raw)
In-Reply-To: 20071105235207.799504040@linux-foundation.org

[-- Attachment #1: sky2-noled-aneg.patch --]
[-- Type: text/plain, Size: 1163 bytes --]

Don't need to change LED's after auto negotiation, the chip
sets them correctly.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>


--- a/drivers/net/sky2.c	2007-11-05 15:05:00.000000000 -0800
+++ b/drivers/net/sky2.c	2007-11-05 15:05:01.000000000 -0800
@@ -1820,29 +1820,6 @@ static void sky2_link_up(struct sky2_por
 	sky2_write8(hw, SK_REG(port, LNK_LED_REG),
 		    LINKLED_ON | LINKLED_BLINK_OFF | LINKLED_LINKSYNC_OFF);
 
-	if (hw->flags & SKY2_HW_NEWER_PHY) {
-		u16 pg = gm_phy_read(hw, port, PHY_MARV_EXT_ADR);
-		u16 led = PHY_M_LEDC_LOS_CTRL(1);	/* link active */
-
-		switch(sky2->speed) {
-		case SPEED_10:
-			led |= PHY_M_LEDC_INIT_CTRL(7);
-			break;
-
-		case SPEED_100:
-			led |= PHY_M_LEDC_STA1_CTRL(7);
-			break;
-
-		case SPEED_1000:
-			led |= PHY_M_LEDC_STA0_CTRL(7);
-			break;
-		}
-
-		gm_phy_write(hw, port, PHY_MARV_EXT_ADR, 3);
-		gm_phy_write(hw, port, PHY_MARV_PHY_CTRL, led);
-		gm_phy_write(hw, port, PHY_MARV_EXT_ADR, pg);
-	}
-
 	if (netif_msg_link(sky2))
 		printk(KERN_INFO PFX
 		       "%s: Link is up at %d Mbps, %s duplex, flow control %s\n",

-- 
Stephen Hemminger <shemminger@linux-foundation.org>


  parent reply	other threads:[~2007-11-05 23:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-05 23:52 [PATCH 0/7] sky2: update for 2.6.24-rc2 Stephen Hemminger
2007-11-05 23:52 ` [PATCH 1/7] sky2: enable PCI config writes Stephen Hemminger
2007-11-06 17:41   ` Jeff Garzik
2007-11-05 23:52 ` [PATCH 2/7] sky2: status ring race fix Stephen Hemminger
2007-11-05 23:52 ` [PATCH 3/7] sky2: longer PHY delay Stephen Hemminger
2007-11-05 23:52 ` Stephen Hemminger [this message]
2007-11-05 23:52 ` [PATCH 5/7] sky2: remove unneeded mask update Stephen Hemminger
2007-11-05 23:52 ` [PATCH 6/7] sky2: handle advanced error recovery config issues Stephen Hemminger
2007-11-05 23:52 ` [PATCH 7/7] sky2: version 1.20 Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071105235340.143067950@linux-foundation.org \
    --to=shemminger@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.