From: Sam Ravnborg <sam@ravnborg.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: unification of cfufreq/Kconfig
Date: Wed, 7 Nov 2007 17:06:29 +0100 [thread overview]
Message-ID: <20071107160629.GA17238@uranus.ravnborg.org> (raw)
In-Reply-To: <20071107071801.GY26163@stusta.de>
On Wed, Nov 07, 2007 at 08:18:01AM +0100, Adrian Bunk wrote:
> On Wed, Nov 07, 2007 at 08:06:44AM +0100, Sam Ravnborg wrote:
> > On Wed, Nov 07, 2007 at 07:02:20AM +0100, Adrian Bunk wrote:
> > > On Wed, Nov 07, 2007 at 12:01:12AM +0100, Sam Ravnborg wrote:
> > > >...
> > > > config X86_SPEEDSTEP_CENTRINO
> > > > - tristate "Intel Enhanced SpeedStep"
> > > > + tristate "Intel Enhanced SpeedStep (deprecated)"
> > > > select CPU_FREQ_TABLE
> > > > - select X86_SPEEDSTEP_CENTRINO_TABLE
> > > > + select X86_SPEEDSTEP_CENTRINO_TABLE if X86_32
> > > > + depends on X86_64 && ACPI_PROCESSOR
> > > >...
> > >
> > > No.
> > >
> > > depends on ACPI_PROCESSOR if X86_64
> >
> > Gives syntax error.
>
> That happens when you review something without trying it...
>
> depends on (ACPI_PROCESSOR || !X86_64)
Got confused by the if and did the wrong conversion.
To make it look like the other config options I will use:
depends on X86_64 || (X86_32 && ACPI_PROCESSOR)
It is longer but simpler.
Thanks,
Sam
next prev parent reply other threads:[~2007-11-07 16:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 23:01 [PATCH] x86: unification of cfufreq/Kconfig Sam Ravnborg
2007-11-06 23:01 ` [PATCH] x86: start unification of arch/x86/Kconfig.* Sam Ravnborg
2007-11-06 23:01 ` [PATCH] x86: arch/x86/Kconfig.cpu unification Sam Ravnborg
2007-11-06 23:01 ` [PATCH] x86: add X86_32 dependency to i386 specific symbols in Kconfig.i386 Sam Ravnborg
2007-11-06 23:01 ` [PATCH] x86: add X86_64 dependency to x86_64 specific symbols in Kconfig.x86_64 Sam Ravnborg
2007-11-06 23:01 ` [PATCH] x86: copy x86_64 specific Kconfig symbols to Kconifg.i386 Sam Ravnborg
2007-11-06 23:01 ` [PATCH] x86: move all simple arch settings to Kconfig Sam Ravnborg
2007-11-06 23:01 ` [PATCH] x86: move the rest of the menu's " Sam Ravnborg
2007-11-06 23:04 ` [PATCH] x86: unification of cfufreq/Kconfig Sam Ravnborg
2007-11-07 5:46 ` Sam Ravnborg
2007-11-09 18:36 ` Andreas Herrmann
2007-11-09 18:45 ` Thomas Gleixner
2007-11-09 19:41 ` Sam Ravnborg
2007-11-09 19:42 ` Sam Ravnborg
2007-11-12 10:45 ` Adrian Bunk
2007-11-07 6:02 ` Adrian Bunk
2007-11-07 7:06 ` Sam Ravnborg
2007-11-07 7:18 ` Adrian Bunk
2007-11-07 16:06 ` Sam Ravnborg [this message]
2007-11-08 14:51 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2007-11-12 20:54 [PATCH revised] enable make ARCH=x86 (and stay backward compatible) Sam Ravnborg
2007-11-12 21:00 ` [PATCH] x86: unification of cfufreq/Kconfig Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071107160629.GA17238@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=bunk@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.