From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1Ipplz-0000D9-Ly for user-mode-linux-devel@lists.sourceforge.net; Wed, 07 Nov 2007 10:37:07 -0800 Received: from [198.99.130.12] (helo=saraswathi.solana.com) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1Ipplz-0004cP-1p for user-mode-linux-devel@lists.sourceforge.net; Wed, 07 Nov 2007 10:37:07 -0800 Date: Wed, 7 Nov 2007 13:36:43 -0500 From: Jeff Dike Message-ID: <20071107183643.GA8482@c2.user-mode-linux.org> Mime-Version: 1.0 Content-Disposition: inline Subject: [uml-devel] [PATCH 5/5] UML - reconst a parameter List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Andrew Morton Cc: WANG Cong , LKML , uml-devel The previous const-ing patch consted a string which shouldn't have been, and I didn't notice the gcc warning. ubd_setup can't take a const char * because its address is assigned to something which expects a char *arg. Many setups modify the string they are given, they can't be const. Signed-off-by: Jeff Dike --- arch/um/drivers/ubd_kern.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/arch/um/drivers/ubd_kern.c =================================================================== --- linux-2.6.orig/arch/um/drivers/ubd_kern.c 2007-11-07 13:20:45.000000000 -0500 +++ linux-2.6/arch/um/drivers/ubd_kern.c 2007-11-07 13:24:57.000000000 -0500 @@ -444,7 +444,7 @@ __uml_help(ubd_setup, " cluster filesystem and inappropriate at almost all other times.\n\n" ); -static int udb_setup(const char *str) +static int udb_setup(char *str) { printk("udb%s specified on command line is almost certainly a ubd -> " "udb TYPO\n", str); ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759951AbXKGSiX (ORCPT ); Wed, 7 Nov 2007 13:38:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759034AbXKGShO (ORCPT ); Wed, 7 Nov 2007 13:37:14 -0500 Received: from saraswathi.solana.com ([198.99.130.12]:60199 "EHLO saraswathi.solana.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758867AbXKGShN (ORCPT ); Wed, 7 Nov 2007 13:37:13 -0500 Date: Wed, 7 Nov 2007 13:36:43 -0500 From: Jeff Dike To: Andrew Morton Cc: LKML , uml-devel , WANG Cong Subject: [PATCH 5/5] UML - reconst a parameter Message-ID: <20071107183643.GA8482@c2.user-mode-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org The previous const-ing patch consted a string which shouldn't have been, and I didn't notice the gcc warning. ubd_setup can't take a const char * because its address is assigned to something which expects a char *arg. Many setups modify the string they are given, they can't be const. Signed-off-by: Jeff Dike --- arch/um/drivers/ubd_kern.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/arch/um/drivers/ubd_kern.c =================================================================== --- linux-2.6.orig/arch/um/drivers/ubd_kern.c 2007-11-07 13:20:45.000000000 -0500 +++ linux-2.6/arch/um/drivers/ubd_kern.c 2007-11-07 13:24:57.000000000 -0500 @@ -444,7 +444,7 @@ __uml_help(ubd_setup, " cluster filesystem and inappropriate at almost all other times.\n\n" ); -static int udb_setup(const char *str) +static int udb_setup(char *str) { printk("udb%s specified on command line is almost certainly a ubd -> " "udb TYPO\n", str);