From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IpsUk-0001yf-Dr for mharc-grub-devel@gnu.org; Wed, 07 Nov 2007 16:31:30 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IpsUi-0001wh-Us for grub-devel@gnu.org; Wed, 07 Nov 2007 16:31:29 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IpsUh-0001sT-7V for grub-devel@gnu.org; Wed, 07 Nov 2007 16:31:28 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IpsUg-0001s2-T3 for grub-devel@gnu.org; Wed, 07 Nov 2007 16:31:26 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IpsSg-0001Xk-Ft for grub-devel@gnu.org; Wed, 07 Nov 2007 16:29:26 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1IpsS4-0006YA-9z for grub-devel@gnu.org; Wed, 07 Nov 2007 22:28:45 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1IpsRs-0004e0-Go for grub-devel@gnu.org; Wed, 07 Nov 2007 22:28:32 +0100 Date: Wed, 7 Nov 2007 22:28:32 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071107212832.GA17708@thorin> References: <4730DDB8.4090902@nic.fi> <20071107201907.GB10337@thorin> <47322185.2040005@nic.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <47322185.2040005@nic.fi> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: grub2 ChangeLog term/i386/pc/serial.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2007 21:31:29 -0000 On Wed, Nov 07, 2007 at 10:35:17PM +0200, Vesa Jääskeläinen wrote: > > grub_inb() and grub_outb() are based on the inb()/outb() implementation > > from glibc headers, so I kept the same arguments for consistency. > > I see... Once again inconsistency introduced by Unix folks... as AT&T > assembler wouldn't be enough, they then poisons C libs too... oh well... > another thing to try to keep in mind... I always thought the Right Way to do this would be implement it in GCC, so that you can do things like: __some_magic__(PORT_ADDR) |= 0x80; which is much more beatufil than either of: outb (PORT_ADDR, inb (PORT_ADDR) | 0x80); outb (inb (PORT_ADDR) | 0x80, PORT_ADDR); don't you think? (now if someone is bored and takes my suggestion to gcc-patches, that'd make my day...) -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)