All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Paul Mackerras <paulus@samba.org>
Cc: lkml@davidb.org, linux-kernel@vger.kernel.org,
	drepper@redhat.com, mtk-manpages@gmx.net
Subject: Re: compat_sys_times() bogus until jiffies >= 0.
Date: Wed, 7 Nov 2007 22:12:00 -0800	[thread overview]
Message-ID: <20071107221200.f5560df0.akpm@linux-foundation.org> (raw)
In-Reply-To: <18226.41032.912666.467900@cargo.ozlabs.ibm.com>

> On Thu, 8 Nov 2007 16:36:08 +1100 Paul Mackerras <paulus@samba.org> wrote:
> Andrew Morton writes:
> 
> > Yup.  But userspace will already have a fit if either the start or end time
> > advanced into the glibc-thought-that-was-an-error range.
> 
> Not nearly as much of a fit.  The effect on x86 is that values between
> -4095 and -1 are reported as -1, so the end-start difference will be
> out by less than 41 seconds.  That's not nearly as dramatic as a
> difference of 21 million seconds (over 16 years). :)
> 
> I really think that wrapping at 0x7fffffff makes the situation worse,
> not better.
> 

Sure.

So we need to do what you say: never return an error from sys_times() and
change glibc to not perform error-interpretation on sys_times() return
values and recommend that people bypass libc and go direct to the syscall
so they'll work correctly on older glibc.   Lovely.

I wonder what happens with things like F_GETOWN, shmat() and lseek(/dev/mem)
on x86 (things which use force_successful_syscall_return()).  According
to the comment in include/linux/ptrace.h, glibc should be special-casing
these.

  reply	other threads:[~2007-11-08  6:12 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-07 22:47 compat_sys_times() bogus until jiffies >= 0 David Brown
2007-11-07 23:28 ` Andrew Morton
2007-11-08  0:18   ` Andrew Morton
2007-11-08  0:54     ` Andreas Schwab
2007-11-08  1:17       ` Andrew Morton
2007-11-08  1:53     ` Paul Mackerras
2007-11-08  2:09       ` David Miller
2007-11-08 10:20         ` Andreas Schwab
2007-11-08 14:42           ` Chris Friesen
2007-11-09 18:20             ` Ulrich Drepper
2007-12-20 11:36               ` Michael Kerrisk
2007-12-20 11:51                 ` David Miller
2007-12-22  0:42                   ` Andi Kleen
2007-12-22  1:41                     ` David Miller
2007-12-22  1:45                       ` David Miller
2007-12-22  1:53                         ` Andi Kleen
2007-12-22  4:36                           ` David Miller
2007-12-22 12:47                             ` Andi Kleen
2007-12-22  1:49                       ` Andi Kleen
2007-11-08 19:25         ` Denys Vlasenko
2007-11-08  3:07       ` Andrew Morton
2007-11-08  3:13         ` David Miller
2007-11-08  5:15           ` Paul Mackerras
2007-11-08  6:24             ` David Miller
2007-11-08  4:59         ` Paul Mackerras
2007-11-08  5:20           ` Andrew Morton
2007-11-08  5:36             ` Paul Mackerras
2007-11-08  6:12               ` Andrew Morton [this message]
2007-11-08  6:25             ` David Miller
2007-11-08  7:09               ` Andrew Morton
2007-11-08  7:14                 ` David Miller
2007-11-08  8:53               ` Paul Mackerras
2007-11-08  6:22           ` David Miller
2007-11-08 19:27         ` Denys Vlasenko
2007-11-08  0:50   ` David Miller
2007-11-08  1:13     ` Andrew Morton
2007-11-08  6:00   ` David Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071107221200.f5560df0.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=drepper@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@davidb.org \
    --cc=mtk-manpages@gmx.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.