From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ipu4T-0004f5-R3 for qemu-devel@nongnu.org; Wed, 07 Nov 2007 18:12:29 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ipu4R-0004dC-8B for qemu-devel@nongnu.org; Wed, 07 Nov 2007 18:12:29 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ipu4Q-0004d1-NS for qemu-devel@nongnu.org; Wed, 07 Nov 2007 18:12:26 -0500 Received: from relay01.mx.bawue.net ([193.7.176.67]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IptZj-0006oB-Im for qemu-devel@nongnu.org; Wed, 07 Nov 2007 17:40:43 -0500 Date: Wed, 7 Nov 2007 22:40:40 +0000 From: Thiemo Seufer Subject: Re: [Qemu-devel] Removal of some target CPU macros Message-ID: <20071107224040.GL9561@networkno.de> References: <473204A2.3030208@bellard.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <473204A2.3030208@bellard.org> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabrice Bellard Cc: qemu-devel@nongnu.org Fabrice Bellard wrote: > I noticed that some target CPUs macros have been added while they do not > seem necessary. I don't like that because it introduces more #ifdefs > which prevent making a version supporting simultaneously all the CPUs. > > In particular I saw the following: > > - TARGET_MIPSN32 : it is always combined with TARGET_MIPS64 in > target-mips/. If its only usage is to select a different Linux ABI, then > I suggest keeping TARGET_MIPS64 and using another define to choose that. I used both in combination to avoid unintended differences in CPU behaviour. I agree it is somewhat ugly, and ABI specific defines would be better. I will make a patch when I find time for it. Thiemo