All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: magnus.damm@gmail.com, netdev@vger.kernel.org,
	lethal@linux-sh.org, ben-linux@fluff.org, jeff@garzik.org,
	linux-arch@vger.kernel.org
Subject: Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)
Date: Thu, 8 Nov 2007 01:02:47 -0800	[thread overview]
Message-ID: <20071108010247.3144394c.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071108081854.GN8181@ftp.linux.org.uk>

> On Thu, 8 Nov 2007 08:18:54 +0000 Al Viro <viro@ftp.linux.org.uk> wrote:
> On Thu, Nov 08, 2007 at 04:31:05PM +0900, Magnus Damm wrote:
> >  config AX88796
> >  	tristate "ASIX AX88796 NE2000 clone support"
> > -	depends on ARM || MIPS
> > +	depends on ARM || MIPS || SUPERH
> 
> You know, that really sucks more and more.  How about doing the following:
> 	a) making it depend on PLAT_HAS_AX88796
> 	b) adding selects for all subarchitectures that have the corresponding
> platform device
> and setting that as a uniform policy for platform drivers?

Yup, but we should be religious about the naming conventions.  ARCH_HAS_
and PLAT_HAS_ followed by the exact name of the thus-enabled config option.

>  For things like
> SM501 we would do
> config MFD_SM501
> 	depends on PCI || PLAT_HAS_SM501
> etc.

See, bug.  That should be PLAT_HAS_MFD_SM501

> Seriously, folks, we are getting shitloads of platform drivers with no
> dependencies whatsoever, needed on a handful of targets and occasionally
> failing to build on unrelated architectures.  Moreover, having a list
> of architectures in dependencies for each of those suckers is a PITA
> from the conflict POV.  Not to mention platform drivers that fall into
> the mainline kernel with not a single platform device for them, etc.
> 
> Comments?

grep PPC drivers/*/Kconfig and weep.

  reply	other threads:[~2007-11-08  9:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-08  7:31 ax88796: add superh to kconfig dependencies Magnus Damm
2007-11-08  8:12 ` Paul Mundt
2007-11-08  8:18 ` [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies) Al Viro
2007-11-08  9:02   ` Andrew Morton [this message]
2007-11-09  9:26   ` Ralf Baechle
2007-11-09  9:40     ` Paul Mundt
2007-11-09 12:02       ` Russell King
2007-11-09 12:02         ` Russell King
2007-11-09 12:08       ` Ben Dooks
2007-11-09 12:08         ` Ben Dooks
2007-11-09 12:06   ` Ben Dooks
2007-11-10  3:12     ` Jeff Garzik
2007-11-08 17:47 ` ax88796: add superh to kconfig dependencies Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071108010247.3144394c.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ben-linux@fluff.org \
    --cc=jeff@garzik.org \
    --cc=lethal@linux-sh.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.