From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Thu, 8 Nov 2007 14:31:30 +0100
Subject: [U-Boot-Users] [PATCH] MTD update
In-Reply-To: <2563ac9e0711070614y1a7032e6y351c9b8da1197fa@mail.gmail.com>
References: <2563ac9e0711070329q26216281pd8da90acef57743d@mail.gmail.com>
	<20071107133059.163D8248D3@gemini.denx.de>
	<2563ac9e0711070614y1a7032e6y351c9b8da1197fa@mail.gmail.com>
Message-ID: <200711081431.31194.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi William,

On Wednesday 07 November 2007, William Juul wrote:
> > We don't have YAFFS support in U-Boot ???
>
> My intent is to submit a patch for this as well. A YAFFS patch will
> build on this patch but is logically distinct so I kept it out for now
> as this patch is more than large enough as it is.

Good.

> > > We have set up a git repository were you can pull the patch:
> > > http://git.tandberg.com/tandberg/u-boot.git
> >
> > This is nice, but it is nevertheless mandatory to post the patches
> > here on the list for review.
>
> As I mentioned in my previous post, some of the changes are very big
> and will not fit under the size-limit unless I split single-file
> patches. Stefan Roese kindly suggested that we could set up a git
> server and put the changes there. I can of-course send all the small
> file-patches to the mailing-list and keep the big changes on the git
> server, but since this logically is all one big patch I thought it
> would be better to keep the whole change together on the git-server.
>
> As I see it, the patch can be reviewed from the git-server and
> comments/snippets can be discussed on the mailing-list. Further, as
> partly stated in my post, I consider this to be work in progress, but
> I need help from the community to finish this off. I would then think
> that I (or the maintainer, if he prefers to run this from a branch in
> his git-tree) can incorporate comments and that the maintainer can
> pull this into his tree when/if he and the community feels that this
> is mature enough.

I think it will be best, that I add this new NAND driver code into a branch of 
the u-boot-nand-flash custodian repository. But only after the first issues 
are solved. For example I found quite a lot of coding style issues in your 
patch:

- Leading white spaces
- Trailing white spaces
- Indentation seems to be sometimes with 4 spaces instead of using a tab
- C++ comments (//)

Please clean this up. I'll send a more detailed review soon.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================