From: Matt Mackall <mpm@selenic.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Marin Mitov <mitov@issp.bas.bg>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Andi Kleen <ak@suse.de>
Subject: Re: is minimum udelay() not respected in preemptible SMP kernel-2.6.23?
Date: Thu, 8 Nov 2007 09:43:53 -0600 [thread overview]
Message-ID: <20071108154353.GT19691@waste.org> (raw)
In-Reply-To: <1194513081.6289.130.camel@twins>
On Thu, Nov 08, 2007 at 10:11:21AM +0100, Peter Zijlstra wrote:
> On Wed, 2007-11-07 at 18:20 -0600, Matt Mackall wrote:
>
> > This and other cases
> > (lots of per_cpu users, IIRC) actually want a migrate_disable() which
> > is a proper subset.
>
> The disadvantage of migrate_disable() is that it complicates the
> load-balancer
Hmm, I'm surprised it's more than a one-liner. Something like
if (cannot_migrate(task))
continue;
But I'm certainly not the expert here. Perhaps this one-liner introduces the
"unplannable O(N) overhead" Ingo mentions in the email you referenced.
> but more importantly, that it does bring a form of latencies with it
> that are hard to measure. Using preempt_disable() for these current
> per-cpu users basically forces them to keep it short.
Ok, so maybe we've got implementation issues to tackle. But still: a)
preempt_disable is inherently misdocumentation (preemption is not the
real problem) and b) preemption is a bigger hammer than needed. At the
very least, we should introduce migrate_disable as an alias for
preempt_disable so we can document intent.
At any rate, in the current context, we're talking about actually
disabling preempt in a *delay loop*. Let's find a fix for that.
> Also see:
> http://lkml.org/lkml/2007/7/23/338
Heh, I'd completely forgotten about this thread and thought I was
having an original idea! Must have never seen Ingo's followup.
Ingo's complaint about it being "a per-task BKL" is interesting. I've
occassionally wondered if it makes sense to make some of these
primitives take a "documentation parameter" - a pointer to an object
that does nothing more than indicate the object of interest.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2007-11-08 15:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 17:21 is minimum udelay() not respected in preemptible SMP kernel-2.6.23? Marin Mitov
2007-11-07 20:30 ` Andrew Morton
2007-11-07 23:10 ` Andi Kleen
2007-11-08 0:20 ` Matt Mackall
2007-11-08 0:31 ` Andi Kleen
2007-11-08 1:03 ` Matt Mackall
2007-11-08 1:20 ` Andi Kleen
2007-11-08 2:44 ` Matt Mackall
2007-11-08 11:46 ` Avi Kivity
2007-11-08 15:10 ` Matt Mackall
2007-11-08 9:11 ` Peter Zijlstra
2007-11-08 15:43 ` Matt Mackall [this message]
2007-11-08 11:24 ` Marin Mitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071108154353.GT19691@waste.org \
--to=mpm@selenic.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mitov@issp.bas.bg \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.