Re: [PATCH 1/3] scsi_tgt_lib: Use scsi_init_io instead of scsi_alloc_sgtable

[FUJITA Tomonori <tomof@acm.org>]

On Thu, 08 Nov 2007 16:01:53 +0200
Boaz Harrosh <bharrosh@panasas.com> wrote:

> On Thu, Nov 08 2007 at 15:04 +0200, FUJITA Tomonori <tomof@acm.org> wrote:
> > On Thu, 08 Nov 2007 10:32:56 +0200
> > Benny Halevy <bhalevy@panasas.com> wrote:
> > 
> >> On Nov. 08, 2007, 5:13 +0200, FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
> >>> On Tue, 06 Nov 2007 20:16:19 +0200
> >>> Boaz Harrosh <bharrosh@panasas.com> wrote:
> >>>
> >>>>   - If we export scsi_init_io()/scsi_release_buffers() instead of
> >>>>     scsi_{alloc,free}_sgtable() from scsi_lib than tgt code is
> >>>>     much more insulated from scsi_lib changes. As a bonus it will
> >>>>     also gain bidi capability when it comes.
> >>>>
> >>>> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
> >>> Looks good for me except for this:
> >>>
> >>> ./scripts/checkpatch.pl ~/Mail/kernel/scsi/28814
> >>> ERROR: use tabs not spaces
> >>> #101: FILE: drivers/scsi/scsi_lib.c:741:
> >>> +                                              gfp_t gfp_mask)$
> >> Come on Tomo, tabs should be used for nesting, not for decoration.
> >> This way no matter what's your tab expansion setup is the
> >> code will look correct and will make sense.  The number of space
> > 
> > I've never heard about that rule. I use tabs and minimum spaces for
> > decoration.
> > 
> > But it's just about the style. The patch is fine by me if you like to
> > use only spaces there.
> > 
> > Thanks,
> Thanks Tomo, I'm resending with the way you like it. You are
> the maintainer and you should be comfortable with the code.

Actually, checkpatch complains about scsi_lib part. You don't need my
ACK on that part.


> I do need your Signed-off-by on this. Since you are the maintainer.
> Do you want that we push this through James, or through your tree?

Acked-by instead of Signed-off-by, I guess.

ACK on target mode portion. You can directly send it to James.

Oh, one more trivial stuff. Can you use 'tgt: hoge' subject? We
usually use that style for target mode though it doesn't matter much.

Thanks,