From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: 2.6.24-rc1: OOPS at acpi_battery_update Date: Fri, 9 Nov 2007 01:49:44 -0800 Message-ID: <20071109014944.26adf4e0.akpm@linux-foundation.org> References: <1193652664.22149.4.camel@localhost> <200711050118.34610.rjw@sisk.pl> <20071108155344.GA12231@cataract> <200711081717.00421.rjw@sisk.pl> <47333ACB.6070408@suse.de> <20071108203451.1b7f28c0.akpm@linux-foundation.org> <47342A2B.5020006@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:41097 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751440AbXKIJud (ORCPT ); Fri, 9 Nov 2007 04:50:33 -0500 In-Reply-To: <47342A2B.5020006@suse.de> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Alexey Starikovskiy Cc: rjw@sisk.pl, hannes-kernel@saeurebad.de, listen@selfservix.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Len Brown On Fri, 09 Nov 2007 12:36:43 +0300 Alexey Starikovskiy wrote: > Andrew Morton wrote: > > A> On Thu, 08 Nov 2007 19:35:23 +0300 Alexey Starikovskiy wrote: > >> [remove_cycle_at_battery_removal.patch text/x-patch (1.7KB)] > >> ACPI: Battery: remove cycle from battery removal. > >> > >> From: Alexey Starikovskiy > >> > >> get_property() should not call battery_update() on absent battery to > >> avoid cycle and oops. > >> > >> Signed-off-by: Alexey Starikovskiy > >> Tested-by: Rolf Eike Beer > > > > A patch similar to this one but with an identical changelog was merged into > > Len's tree on November 2. > > > > If it had been promptly merged into mainline then quite a lot of people's > > time would not have been wasted. > > > Andrew, > should I send such patches directly to you/Linus? > Well if Len doesn't object and you're confident in the changes, why not? Any time we leave bugs unfixed we drive away testers and that impacts all parts of the kernel.