From: Chris Mason <chris.mason@oracle.com>
To: Chris Mason <chris.mason@oracle.com>
Cc: Zach Brown <zach.brown@oracle.com>,
Trond Myklebust <trond.myklebust@fys.uio.no>,
Peter Zijlstra <peterz@infradead.org>,
Jens Axboe <jens.axboe@oracle.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-aio@kvack.org
Subject: Re: dio_get_page() lockdep complaints
Date: Fri, 9 Nov 2007 13:57:36 -0500 [thread overview]
Message-ID: <20071109135736.04a4346a@think.oraclecorp.com> (raw)
In-Reply-To: <20071109135327.01bca1d9@think.oraclecorp.com>
On Fri, 9 Nov 2007 13:53:27 -0500
Chris Mason <chris.mason@oracle.com> wrote:
> On Fri, 09 Nov 2007 10:35:04 -0800
> Zach Brown <zach.brown@oracle.com> wrote:
>
> > > Without getting into a huge patch, the best fix would just be
> > > switching to try lock. If the tail doesn't get packed, the world
> > > doesn't end.
> >
> > So, something like this?
>
> Reviewed-by: Chris Mason <chris.mason@oracle.com>
>
Ugh, I thought the preallocation was getting freed elsewhere, but it
looks like I was wrong. We can't just skip the i_mutex after all,
sorry.
-chris
next prev parent reply other threads:[~2007-11-09 18:58 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-19 7:38 dio_get_page() lockdep complaints Jens Axboe
2007-04-19 8:01 ` Andrew Morton
2007-04-19 8:01 ` Andrew Morton
2007-04-19 8:01 ` Jens Axboe
2007-04-19 8:01 ` Jens Axboe
2007-04-19 8:25 ` Andrew Morton
2007-04-19 8:25 ` Andrew Morton
2007-04-19 8:34 ` Jens Axboe
2007-04-19 8:34 ` Jens Axboe
2007-04-19 12:43 ` Vladimir V. Saveliev
2007-04-19 12:43 ` Vladimir V. Saveliev
2007-04-19 12:49 ` Jens Axboe
2007-04-19 12:52 ` Jens Axboe
2007-04-19 12:52 ` Jens Axboe
2007-04-19 13:53 ` Roland Dreier
2007-04-19 13:53 ` Roland Dreier
2007-04-19 14:20 ` Jens Axboe
2007-04-19 14:20 ` Jens Axboe
2007-04-19 14:15 ` Jens Axboe
2007-04-19 14:15 ` Jens Axboe
2007-04-19 14:55 ` Vladimir V. Saveliev
2007-04-19 14:55 ` Vladimir V. Saveliev
2007-04-19 14:57 ` Vladimir V. Saveliev
2007-04-19 14:57 ` Vladimir V. Saveliev
2007-04-19 16:42 ` Andrew Morton
2007-04-19 16:42 ` Andrew Morton
2007-04-19 14:36 ` Chris Mason
2007-04-19 14:36 ` Chris Mason
2007-11-09 17:02 ` Peter Zijlstra
2007-11-09 17:30 ` Zach Brown
2007-11-09 17:45 ` Trond Myklebust
2007-11-09 17:48 ` Zach Brown
2007-11-09 18:01 ` Chris Mason
2007-11-09 18:35 ` Zach Brown
2007-11-09 18:53 ` Chris Mason
2007-11-09 18:57 ` Chris Mason [this message]
2007-11-09 19:16 ` Zach Brown
2007-11-09 19:35 ` Chris Mason
2007-11-11 19:49 ` Peter Zijlstra
2007-11-11 19:49 ` Peter Zijlstra
2007-11-12 8:45 ` Martin Schwidefsky
2007-11-12 8:45 ` Martin Schwidefsky
2007-11-12 9:27 ` Peter Zijlstra
2007-11-12 9:27 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071109135736.04a4346a@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=trond.myklebust@fys.uio.no \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.