From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IqbLx-00062b-Mj for mharc-grub-devel@gnu.org; Fri, 09 Nov 2007 16:25:25 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IqbLw-00060i-Kt for grub-devel@gnu.org; Fri, 09 Nov 2007 16:25:24 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IqbLv-0005zN-Hk for grub-devel@gnu.org; Fri, 09 Nov 2007 16:25:24 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IqbLv-0005zK-EF for grub-devel@gnu.org; Fri, 09 Nov 2007 16:25:23 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IqbLv-0005T3-0C for grub-devel@gnu.org; Fri, 09 Nov 2007 16:25:23 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1IqbLt-0002Xo-QW for grub-devel@gnu.org; Fri, 09 Nov 2007 22:25:22 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1IqbLg-00082D-HD for grub-devel@gnu.org; Fri, 09 Nov 2007 22:25:08 +0100 Date: Fri, 9 Nov 2007 22:25:08 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071109212508.GE23437@thorin> References: <4720F3CA.7070804@t-online.de> <20071109205638.GB23437@thorin> <87bqa3jezk.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bqa3jezk.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Add host open devicename check X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2007 21:25:24 -0000 On Fri, Nov 09, 2007 at 10:17:19PM +0100, Marco Gerards wrote: > Robert Millan writes: > > > On Thu, Oct 25, 2007 at 09:51:38PM +0200, Christian Franke wrote: > >> static grub_err_t > >> -grub_host_open (const char *name __attribute((unused)), grub_disk_t disk) > >> +grub_host_open (const char *name, grub_disk_t disk) > >> { > >> + if (grub_strcmp(name, "host")) > >> + return grub_error (GRUB_ERR_UNKNOWN_DEVICE, "not a host disk"); > >> + > > > > I would test for (disk->id == GRUB_DISK_DEVICE_HOST_ID) instead. Faster, > > and also cleaner/simpler IMHO. > > It's not possible unfortunately :-(. This information is about to be > filled in in this same function. Still seems like an ugly hack to me. Oh well :-/ > Besides that, you have grub_disk_dev > in mind. Ouch ;-) -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)