From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IqbUb-0005C1-Ay for mharc-grub-devel@gnu.org; Fri, 09 Nov 2007 16:34:21 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IqbUZ-0005B0-W8 for grub-devel@gnu.org; Fri, 09 Nov 2007 16:34:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IqbUY-00059r-Rl for grub-devel@gnu.org; Fri, 09 Nov 2007 16:34:19 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IqbUY-00059k-PT for grub-devel@gnu.org; Fri, 09 Nov 2007 16:34:18 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IqbUY-00085u-GF for grub-devel@gnu.org; Fri, 09 Nov 2007 16:34:18 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1IqbUU-0002YH-A4 for grub-devel@gnu.org; Fri, 09 Nov 2007 22:34:14 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1IqbUH-00086Q-7n for grub-devel@gnu.org; Fri, 09 Nov 2007 22:34:01 +0100 Date: Fri, 9 Nov 2007 22:34:01 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071109213401.GG23437@thorin> References: <20071107205340.GA16687@thorin> <87640bl9ln.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87640bl9ln.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] fix serial console on LinuxBIOS X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2007 21:34:20 -0000 On Fri, Nov 09, 2007 at 04:30:44PM +0100, Marco Gerards wrote: > Robert Millan writes: > > > This patch fixes serial console on LinuxBIOS. > > > > I'd appreciate comments (specially on the addition). > > > > -- > > Robert Millan > > > > I know my rights; I want my phone call! > > What use is a phone call, if you are unable to speak? > > (as seen on /.) > > > > No header ;) Uhm what header? > > * include/grub/i386/efi/machine.h: New file. > > * include/grub/i386/linuxbios/machine.h: Likewise. > > * include/grub/i386/pc/machine.h: Likewise. > > * include/grub/powerpc/ieee1275/machine.h: Likewise. > > * include/grub/sparc64/ieee1275/machine.h: Likewise. > > > > * term/i386/pc/serial.c: Include . > > (serial_hw_io_addr): New variable. > > (serial_hw_get_port): Obtain port address from `serial_hw_io_addr' > > instead of `(unsigned short *) 0x400'. > > This seems fine to me. What is your intended use for machine.h? More > than just this? Situations very similar to this one, in that you just need to change a few unportable lines while the overall structure of the file remains portable. > Perhaps we can even use autoconf to define this in config.h? That > would be better I think. autoconf already setups the cpu / machine symlinks. Why ask it to tell the same info twice? -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)