From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IqbY1-0007m1-Pp for mharc-grub-devel@gnu.org; Fri, 09 Nov 2007 16:37:53 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IqbXy-0007g2-WA for grub-devel@gnu.org; Fri, 09 Nov 2007 16:37:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IqbXw-0007br-Bv for grub-devel@gnu.org; Fri, 09 Nov 2007 16:37:49 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IqbXw-0007bg-8v for grub-devel@gnu.org; Fri, 09 Nov 2007 16:37:48 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IqbXv-0000WV-Sx for grub-devel@gnu.org; Fri, 09 Nov 2007 16:37:48 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1IqbXu-0002YX-M9 for grub-devel@gnu.org; Fri, 09 Nov 2007 22:37:47 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1IqbXh-000888-8g for grub-devel@gnu.org; Fri, 09 Nov 2007 22:37:33 +0100 Date: Fri, 9 Nov 2007 22:37:33 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071109213733.GH23437@thorin> References: <4730DDB8.4090902@nic.fi> <20071107201907.GB10337@thorin> <47322185.2040005@nic.fi> <20071107212832.GA17708@thorin> <87abpnl9th.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87abpnl9th.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: grub2 ChangeLog term/i386/pc/serial.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2007 21:37:51 -0000 On Fri, Nov 09, 2007 at 04:26:02PM +0100, Marco Gerards wrote: > > > > I always thought the Right Way to do this would be implement it in GCC, > > so that you can do things like: > > > > __some_magic__(PORT_ADDR) |= 0x80; > > > > which is much more beatufil than either of: > > > > outb (PORT_ADDR, inb (PORT_ADDR) | 0x80); > > > > outb (inb (PORT_ADDR) | 0x80, PORT_ADDR); > > > > don't you think? > > > > (now if someone is bored and takes my suggestion to gcc-patches, that'd make > > my day...) > > That's possible in C++ using operator overloading AFAIK. Ah, right. Maybe we could switch to building with g++ just to get this feature ;-) > Did this commit fix serial support for LB? No, it fixed a bug affecting all platforms (i.e. both of them ;-)). For serial.mod to work on LB, we need the other patch (the machine.h one). -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)