From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Iqxon-0007eL-JB for mharc-grub-devel@gnu.org; Sat, 10 Nov 2007 16:24:41 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Iqxol-0007cE-Bc for grub-devel@gnu.org; Sat, 10 Nov 2007 16:24:39 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Iqxoj-0007a3-3V for grub-devel@gnu.org; Sat, 10 Nov 2007 16:24:38 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iqxoi-0007Zv-UY for grub-devel@gnu.org; Sat, 10 Nov 2007 16:24:36 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Iqxoi-00064i-V4 for grub-devel@gnu.org; Sat, 10 Nov 2007 16:24:37 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Iqxoh-0004nn-C9 for grub-devel@gnu.org; Sat, 10 Nov 2007 22:24:35 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1IqxoT-0004kW-QB for grub-devel@gnu.org; Sat, 10 Nov 2007 22:24:21 +0100 Date: Sat, 10 Nov 2007 22:24:21 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071110212421.GI15633@thorin> References: <4736009D.3010502@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4736009D.3010502@t-online.de> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Handle C symbols with leading underscore (HAVE_ASM_USCORE) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Nov 2007 21:24:39 -0000 On Sat, Nov 10, 2007 at 08:03:57PM +0100, Christian Franke wrote: > > This patch fixes this by ignoring the difference. It actually works to > load modules compiled on Linux by a kernel compiled on Cygwin (with > underscores) and vice versa. > > [...] > + > + /* Ignore leading underscore used for C symbols. > + Done at runtime to allow loading modules compiled on other OS. */ > + if (*name == '_') > + name++; Is that something we really want? We never made any efforts at maintaining ABI between kernel and modules, or in allowing this kind of combinations. If we go this path, it can mean more work later (e.g. support for building kernel and modules with different versions of GCC, etc). Could you give an example of a situation in which this would be useful? -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)