From: Andrew Morton <akpm@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Erez Zadok <ezk@cs.sunysb.edu>,
linux-kernel@vger.kernel.org, Ulrich Drepper <drepper@redhat.com>,
Roland McGrath <roland@redhat.com>,
"Andrew G. Morgan" <morgan@kernel.org>,
Casey Schaufler <casey@schaufler-ca.com>,
Chris Wright <chrisw@sous-sol.org>,
James Morris <jmorris@namei.org>, Serge Hallyn <serue@us.ibm.com>,
Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)
Date: Sun, 11 Nov 2007 11:30:16 -0800 [thread overview]
Message-ID: <20071111113016.6956ce70.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071111141510.GA29126@elte.hu>
On Sun, 11 Nov 2007 15:15:10 +0100 Ingo Molnar <mingo@elte.hu> wrote:
>
> * Erez Zadok <ezk@cs.sunysb.edu> wrote:
>
> > Small patch below fixes compile error.
>
> > + char name[sizeof(current->comm)];
> > warned++;
> > printk(KERN_INFO
> > "warning: process `%s' sets w/ old libcap\n",
> > - get_task_comm(current));
> > + get_task_comm(name, current));
>
> that's buggy - get_task_comm() returns void.
>
> the proper fix would be to first do a get_task_comm() then pass in
> 'name' as an argument to printk.
yup, it is all dependent upon http://lkml.org/lkml/2007/11/8/231
prev parent reply other threads:[~2007-11-11 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 1:01 [PATCH] kernel/capability.c get_task_comm compile error (MMOTM) Erez Zadok
2007-11-11 14:15 ` Ingo Molnar
2007-11-11 17:11 ` Erez Zadok
2007-11-11 20:44 ` Ingo Molnar
2007-11-11 19:30 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071111113016.6956ce70.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=casey@schaufler-ca.com \
--cc=chrisw@sous-sol.org \
--cc=drepper@redhat.com \
--cc=ezk@cs.sunysb.edu \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=morgan@kernel.org \
--cc=roland@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.