From: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] error compiling hw/sh7750.c
Date: Sun, 11 Nov 2007 12:03:48 -0600 [thread overview]
Message-ID: <20071111180348.GB9387@tapir> (raw)
In-Reply-To: <200711111724.08081.paul@codesourcery.com>
On Sun, Nov 11, 2007 at 05:24:06PM +0000, Paul Brook wrote:
> > +#undef NULL
> > +#define NULL ((void *)0)
>
> Absolutely not.
this was not meant to be a final solution, or even be committed in qemu, just
a stop gap solution answering Ben so that he can get their build to complete
and have a somehow equivalent definition of what the code is doing in linux
(where I presume was tested) until it can be fixed in a portable way.
Ben's solution was to replace _INTC_ARRAY(NULL) with "NULL, NULL" but it
should had been instead "NULL, 4" or "NULL, 8" depending on what ISA he is
compiling it for, doing the "#undef/#define" leads to that and, yes I agree
it is awful.
Carlo
next prev parent reply other threads:[~2007-11-11 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 14:30 [Qemu-devel] error compiling hw/sh7750.c Ben Taylor
2007-11-11 16:06 ` Carlo Marcelo Arenas Belon
2007-11-11 17:21 ` Carlo Marcelo Arenas Belon
2007-11-11 17:24 ` Paul Brook
2007-11-11 18:03 ` Carlo Marcelo Arenas Belon [this message]
2007-11-11 17:46 ` M. Warner Losh
2007-11-11 17:49 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071111180348.GB9387@tapir \
--to=carenas@sajinet.com.pe \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.