From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, tony@bakeyournoodle.com,
paulus@samba.org, dino@in.ibm.com, tytso@us.ibm.com,
dvhltc@us.ibm.com, niv@us.ibm.com, antonb@us.ibm.com
Subject: Re: [PATCH, RFC] improved hacks to allow -rt to run kernbench on POWER
Date: Mon, 12 Nov 2007 09:05:21 -0800 [thread overview]
Message-ID: <20071112170521.GA11113@linux.vnet.ibm.com> (raw)
In-Reply-To: <1194814125.6510.14.camel@pasglop>
On Mon, Nov 12, 2007 at 07:48:45AM +1100, Benjamin Herrenschmidt wrote:
>
> On Sun, 2007-11-11 at 09:45 -0500, Steven Rostedt wrote:
> > > Well, I suppose the patch could go in, maybe with some ifdef's
> > around
> > > the bits in _switch_to, there's little point in doing that on non-rt
> > > kernels.
> >
> > As Nick Piggin already stated, and I'll even state it for the RT
> > kernel,
> > we do not allow preemption in switch_to. So it is safe to remove those
> > "preempt_disable" bits from the patch
>
> Sure, I know that, I'm not talking about that, I'm talking about the
> added code that flush pending batches & save the batch state, since on
> non-rt kernel, this is not useful (the batch is only ever active within
> a spinlocked section, which cannot be preempted on non-rt).
Ah, I need a bit of conditional compilation. Will fix.
Thanx, Paul
next prev parent reply other threads:[~2007-11-12 17:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-09 18:10 [PATCH, RFC] improved hacks to allow -rt to run kernbench on POWER Paul E. McKenney
2007-11-09 20:52 ` Benjamin Herrenschmidt
2007-11-09 22:07 ` Paul E. McKenney
2007-11-11 3:59 ` Benjamin Herrenschmidt
2007-11-11 14:45 ` Steven Rostedt
2007-11-11 20:48 ` Benjamin Herrenschmidt
2007-11-12 17:05 ` Paul E. McKenney [this message]
2007-11-12 19:15 ` Paul E. McKenney
2007-11-12 21:12 ` Benjamin Herrenschmidt
2007-11-13 9:10 ` Peter Zijlstra
2007-11-13 9:43 ` Benjamin Herrenschmidt
2007-11-13 10:05 ` Peter Zijlstra
2007-11-13 10:59 ` Peter Zijlstra
2007-11-13 11:09 ` Benjamin Herrenschmidt
2007-11-10 1:18 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071112170521.GA11113@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=antonb@us.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=dino@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=niv@us.ibm.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=tony@bakeyournoodle.com \
--cc=tytso@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.