From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 12/24] [IPSEC]: Forbid BEET + ipcomp for now
Date: Tue, 13 Nov 2007 21:39:18 -0800 (PST) [thread overview]
Message-ID: <20071113.213918.51461693.davem@davemloft.net> (raw)
In-Reply-To: <E1Ipla0-0001HT-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 07 Nov 2007 22:08:28 +0800
> [IPSEC]: Forbid BEET + ipcomp for now
>
> While BEET can theoretically work with IPComp the current code can't do that
> because it tries to construct a BEET mode tunnel type which doesn't (and
> cannot) exist. In fact as it is it won't even attach a tunnel object at
> all for BEET which is bogus.
>
> To support this fully we'd also need to change the policy checks on input
> to recognise a plain tunnel as a legal variant of an optional BEET transform.
>
> This patch simply fails such constructions for now.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied to net-2.6.25
next prev parent reply other threads:[~2007-11-14 5:39 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 14:07 [0/24] Merge IPv4/IPv6 IPsec bundle creation and input/ouput Herbert Xu
2007-11-07 14:08 ` [PATCH 1/24] [IPV6]: Only set nfheader_len for top xfrm dst Herbert Xu
2007-11-14 5:32 ` David Miller
2007-11-07 14:08 ` [PATCH 2/24] [IPSEC]: Use dst->header_len when resizing on output Herbert Xu
2007-11-14 5:33 ` David Miller
2007-11-07 14:08 ` [PATCH 3/24] [IPV6]: Move nfheader_len into rt6_info Herbert Xu
2007-11-14 5:33 ` David Miller
2007-11-07 14:08 ` [PATCH 4/24] [NET]: Eliminate duplicate copies of dst_discard Herbert Xu
2007-11-14 5:34 ` David Miller
2007-11-07 14:08 ` [PATCH 5/24] [NET]: Remove unnecessary inclusion of dst.h Herbert Xu
2007-11-14 5:34 ` David Miller
2007-11-07 14:08 ` [PATCH 6/24] [IPSEC]: Only set neighbour on top xfrm dst Herbert Xu
2007-11-14 5:35 ` David Miller
2007-11-07 14:08 ` [PATCH 7/24] [IPSEC]: Set dst->input to dst_discard Herbert Xu
2007-11-14 5:35 ` David Miller
2007-11-07 14:08 ` [PATCH 8/24] [IPSEC]: Make sure idev is consistent with dev in xfrm_dst Herbert Xu
2007-11-14 5:36 ` David Miller
2007-11-07 14:08 ` [PATCH 9/24] [IPSEC]: Replace x->type->{local,remote}_addr with flags Herbert Xu
2007-11-14 5:37 ` David Miller
2007-11-07 14:08 ` [PATCH 10/24] [IPSEC]: Move flow construction into xfrm_dst_lookup Herbert Xu
2007-11-14 5:37 ` David Miller
2007-11-07 14:08 ` [PATCH 11/24] [IPSEC]: Merge common code into xfrm_bundle_create Herbert Xu
2007-11-14 5:38 ` David Miller
2007-11-07 14:08 ` [PATCH 12/24] [IPSEC]: Forbid BEET + ipcomp for now Herbert Xu
2007-11-14 5:39 ` David Miller [this message]
2007-11-07 14:08 ` [PATCH 13/24] [IPSEC]: Move x->outer_mode->output out of locked section Herbert Xu
2007-11-07 16:17 ` Ingo Oeser
2007-11-08 0:39 ` Herbert Xu
2007-11-13 11:33 ` David Miller
2007-11-13 11:51 ` Herbert Xu
2007-11-14 5:47 ` David Miller
2007-11-14 5:39 ` David Miller
2007-11-07 14:08 ` [PATCH 14/24] [INET]: Give outer DSCP directly to ip*_copy_dscp Herbert Xu
2007-11-14 5:40 ` David Miller
2007-11-07 14:08 ` [PATCH 15/24] [IPSEC]: Separate inner/outer mode processing on output Herbert Xu
2007-11-14 5:41 ` David Miller
2007-11-07 14:08 ` [PATCH 16/24] [IPSEC]: Separate inner/outer mode processing on input Herbert Xu
2007-11-14 5:41 ` David Miller
2007-11-07 14:08 ` [PATCH 17/24] [IPV4]: Add ip_local_out Herbert Xu
2007-11-14 5:42 ` David Miller
2007-11-07 14:08 ` [PATCH 18/24] [IPV6]: Add ip6_local_out Herbert Xu
2007-11-14 5:42 ` David Miller
2007-11-07 14:08 ` [PATCH 19/24] [IPSEC]: Merge most of the output path Herbert Xu
2007-11-08 11:23 ` Patrick McHardy
2007-11-08 11:29 ` Herbert Xu
2007-11-14 9:07 ` David Miller
2007-11-14 9:14 ` Patrick McHardy
2007-11-14 9:16 ` Herbert Xu
2007-11-14 9:19 ` Patrick McHardy
2007-11-14 5:43 ` David Miller
2007-11-07 14:08 ` [PATCH 20/24] [IPSEC]: Add async resume support on output Herbert Xu
2007-11-14 5:44 ` David Miller
2007-11-07 14:08 ` [PATCH 21/24] [IPSEC]: Merge most of the input path Herbert Xu
2007-11-14 5:44 ` David Miller
2007-11-07 14:08 ` [PATCH 22/24] [IPSEC]: Store xfrm states in security path directly Herbert Xu
2007-11-14 5:45 ` David Miller
2007-11-07 14:08 ` [PATCH 23/24] [IPSEC]: Move integrity stat collection into xfrm_input Herbert Xu
2007-11-14 5:45 ` David Miller
2007-11-07 14:08 ` [PATCH 24/24] [IPSEC]: Move state lock into x->type->input Herbert Xu
2007-11-14 5:46 ` David Miller
2007-11-14 6:27 ` [PATCH 1/2] [IPSEC]: Remove nhoff from xfrm_input Herbert Xu
2007-11-14 6:28 ` [PATCH 2/2] [IPSEC]: Add async resume support on input Herbert Xu
2007-11-14 6:33 ` David Miller
2007-11-14 6:36 ` Herbert Xu
2007-11-14 6:38 ` David Miller
2007-11-14 6:41 ` Herbert Xu
2007-11-14 6:46 ` David Miller
2007-11-14 9:58 ` David Miller
2007-11-14 10:04 ` Herbert Xu
2007-11-14 9:05 ` Patrick McHardy
2007-11-14 6:32 ` [PATCH 1/2] [IPSEC]: Remove nhoff from xfrm_input David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071113.213918.51461693.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.